Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: base/synchronization/lock_unittest.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/synchronization/condition_variable_unittest.cc ('k') | base/task_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/synchronization/lock.h" 5 #include "base/synchronization/lock.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/threading/platform_thread.h" 10 #include "base/threading/platform_thread.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace base { 13 namespace base {
14 14
15 // Basic test to make sure that Acquire()/Release()/Try() don't crash ---------- 15 // Basic test to make sure that Acquire()/Release()/Try() don't crash ----------
16 16
17 class BasicLockTestThread : public PlatformThread::Delegate { 17 class BasicLockTestThread : public PlatformThread::Delegate {
18 public: 18 public:
19 BasicLockTestThread(Lock* lock) : lock_(lock), acquired_(0) {} 19 explicit BasicLockTestThread(Lock* lock) : lock_(lock), acquired_(0) {}
20 20
21 virtual void ThreadMain() OVERRIDE { 21 virtual void ThreadMain() OVERRIDE {
22 for (int i = 0; i < 10; i++) { 22 for (int i = 0; i < 10; i++) {
23 lock_->Acquire(); 23 lock_->Acquire();
24 acquired_++; 24 acquired_++;
25 lock_->Release(); 25 lock_->Release();
26 } 26 }
27 for (int i = 0; i < 10; i++) { 27 for (int i = 0; i < 10; i++) {
28 lock_->Acquire(); 28 lock_->Acquire();
29 acquired_++; 29 acquired_++;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 PlatformThread::Join(handle); 84 PlatformThread::Join(handle);
85 85
86 EXPECT_GE(acquired, 20); 86 EXPECT_GE(acquired, 20);
87 EXPECT_GE(thread.acquired(), 20); 87 EXPECT_GE(thread.acquired(), 20);
88 } 88 }
89 89
90 // Test that Try() works as expected ------------------------------------------- 90 // Test that Try() works as expected -------------------------------------------
91 91
92 class TryLockTestThread : public PlatformThread::Delegate { 92 class TryLockTestThread : public PlatformThread::Delegate {
93 public: 93 public:
94 TryLockTestThread(Lock* lock) : lock_(lock), got_lock_(false) {} 94 explicit TryLockTestThread(Lock* lock) : lock_(lock), got_lock_(false) {}
95 95
96 virtual void ThreadMain() OVERRIDE { 96 virtual void ThreadMain() OVERRIDE {
97 got_lock_ = lock_->Try(); 97 got_lock_ = lock_->Try();
98 if (got_lock_) 98 if (got_lock_)
99 lock_->Release(); 99 lock_->Release();
100 } 100 }
101 101
102 bool got_lock() const { return got_lock_; } 102 bool got_lock() const { return got_lock_; }
103 103
104 private: 104 private:
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 MutexLockTestThread::DoStuff(&lock, &value); 207 MutexLockTestThread::DoStuff(&lock, &value);
208 208
209 PlatformThread::Join(handle1); 209 PlatformThread::Join(handle1);
210 PlatformThread::Join(handle2); 210 PlatformThread::Join(handle2);
211 PlatformThread::Join(handle3); 211 PlatformThread::Join(handle3);
212 212
213 EXPECT_EQ(4 * 40, value); 213 EXPECT_EQ(4 * 40, value);
214 } 214 }
215 215
216 } // namespace base 216 } // namespace base
OLDNEW
« no previous file with comments | « base/synchronization/condition_variable_unittest.cc ('k') | base/task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698