Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: base/message_pump_libevent_unittest.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/memory/ref_counted_memory.h ('k') | base/metrics/bucket_ranges.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_pump_libevent.h" 5 #include "base/message_pump_libevent.h"
6 6
7 #include <unistd.h> 7 #include <unistd.h>
8 8
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/posix/eintr_wrapper.h" 10 #include "base/posix/eintr_wrapper.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 ASSERT_DEATH(io_loop()->WatchFileDescriptor( 78 ASSERT_DEATH(io_loop()->WatchFileDescriptor(
79 STDOUT_FILENO, false, MessageLoopForIO::WATCH_READ, &watcher, &delegate), 79 STDOUT_FILENO, false, MessageLoopForIO::WATCH_READ, &watcher, &delegate),
80 "Check failed: " 80 "Check failed: "
81 "watch_file_descriptor_caller_checker_.CalledOnValidThread()"); 81 "watch_file_descriptor_caller_checker_.CalledOnValidThread()");
82 } 82 }
83 83
84 #endif // GTEST_HAS_DEATH_TEST && !defined(NDEBUG) 84 #endif // GTEST_HAS_DEATH_TEST && !defined(NDEBUG)
85 85
86 class BaseWatcher : public MessagePumpLibevent::Watcher { 86 class BaseWatcher : public MessagePumpLibevent::Watcher {
87 public: 87 public:
88 BaseWatcher(MessagePumpLibevent::FileDescriptorWatcher* controller) 88 explicit BaseWatcher(MessagePumpLibevent::FileDescriptorWatcher* controller)
89 : controller_(controller) { 89 : controller_(controller) {
90 DCHECK(controller_); 90 DCHECK(controller_);
91 } 91 }
92 virtual ~BaseWatcher() {} 92 virtual ~BaseWatcher() {}
93 93
94 // base:MessagePumpLibevent::Watcher interface 94 // base:MessagePumpLibevent::Watcher interface
95 virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE { 95 virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE {
96 NOTREACHED(); 96 NOTREACHED();
97 } 97 }
98 98
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 pump->WatchFileDescriptor(pipefds_[1], 153 pump->WatchFileDescriptor(pipefds_[1],
154 false, MessagePumpLibevent::WATCH_READ_WRITE, &watcher, &delegate); 154 false, MessagePumpLibevent::WATCH_READ_WRITE, &watcher, &delegate);
155 155
156 // Spoof a libevent notification. 156 // Spoof a libevent notification.
157 OnLibeventNotification(pump, &watcher); 157 OnLibeventNotification(pump, &watcher);
158 } 158 }
159 159
160 } // namespace 160 } // namespace
161 161
162 } // namespace base 162 } // namespace base
OLDNEW
« no previous file with comments | « base/memory/ref_counted_memory.h ('k') | base/metrics/bucket_ranges.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698