Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 11419192: Make PPAPI headers compilable with -Wstrict-prototypes (Closed)

Created:
8 years ago by Mark Seaborn
Modified:
8 years ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Make PPAPI headers compilable with -Wstrict-prototypes This changes the PPAPI headers to use "foo(void)" rather than "foo()" in function prototypes and definitions. In C (but not C++), "foo()" declares a function with unspecified arguments, which allows foo to be called with excess arguments or implemented with excess arguments. Using "foo(void)" is more correct and will prevent such mistakes. GCC's -Wstrict-prototypes warning requires using "foo(void)", and we'd like to turn this warning on for NaCl C code. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3114 TEST= rerun ppapi/generators/generator.py + compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M ppapi/c/dev/ppb_testing_dev.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/c/ppb_core.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/c/ppb_image_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/ppb_message_loop.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/c/ppp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/private/ppb_gpu_blacklist_private.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ppapi/generators/idl_c_proto.py View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 9 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
8 years ago (2012-11-29 00:21:32 UTC) #1
brettw
8 years ago (2012-11-29 00:26:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698