Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: runtime/vm/parser.cc

Issue 11419176: Eliminate support of legacy type Dyamic (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/html/instance_of_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 15402)
+++ runtime/vm/parser.cc (working copy)
@@ -29,8 +29,6 @@
DEFINE_FLAG(bool, silent_warnings, false, "Silence warnings.");
DEFINE_FLAG(bool, warn_legacy_map_literal, false,
"Warning on legacy map literal syntax (single type argument)");
-DEFINE_FLAG(bool, warn_legacy_dynamic, false,
- "Warning on legacy type Dynamic)");
DEFINE_FLAG(bool, warn_legacy_getters, false,
"Warning on legacy getter syntax");
DEFINE_FLAG(bool, strict_function_literals, false,
@@ -6723,9 +6721,7 @@
ErrorMsg("%s", msg);
}
String* ident = CurrentLiteral();
- // TODO(hausner): Remove check for 'Dynamic' once support for upper-case
- // type dynamic is gone.
- if (ident->Equals("Dynamic") || ident->Equals("dynamic")) {
+ if (ident->Equals("dynamic")) {
ErrorMsg("%s", msg);
}
ConsumeToken();
@@ -8603,16 +8599,6 @@
SkipQualIdent();
} else {
ParseQualIdent(&type_name);
- // TODO(hausner): Remove this once support for legacy type 'Dynamic'
- // is removed.
- if ((type_name.lib_prefix == NULL) && type_name.ident->Equals("Dynamic")) {
- if (FLAG_warn_legacy_dynamic) {
- Warning(type_name.ident_pos,
- "legacy type 'Dynamic' found; auto-converting to 'dynamic'");
- }
- // Replace with lower-case 'dynamic'.
- *type_name.ident ^= Symbols::Dynamic();
- }
// An identifier cannot be resolved in a local scope when top level parsing.
if (!is_top_level_ &&
(type_name.lib_prefix == NULL) &&
« no previous file with comments | « no previous file | tests/html/instance_of_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698