Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5828)

Unified Diff: chrome/browser/download/download_util.cc

Issue 11419169: Use DownloadItemModel for storing chrome/ specific UI data for DownloadItems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.cc
diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc
index 3d2dc09983a19c0bc96872de9306260085b92644..583314256aeafc7fecd62249ce89e7d39c8a1dbd 100644
--- a/chrome/browser/download/download_util.cc
+++ b/chrome/browser/download/download_util.cc
@@ -75,21 +75,6 @@
namespace {
-// Key used to attach ShowInShelfData to a DownloadItem.
-const char kShowInShelfKey[] = "chrome.download_util.show_in_shelf";
-
-// Class that tracks the "show in download shelf" setting for a download item.
-class ShowInShelfData : public base::SupportsUserData::Data {
- public:
- explicit ShowInShelfData(bool should_show) : should_show_(should_show) {
- }
-
- bool should_show() const { return should_show_; }
-
- private:
- const bool should_show_;
-};
-
// Get the opacity based on |animation_progress|, with values in [0.0, 1.0].
// Range of return value is [0, 255].
int GetOpacity(double animation_progress) {
@@ -516,14 +501,4 @@ void RecordDownloadSource(ChromeDownloadSource source) {
"Download.SourcesChrome", source, CHROME_DOWNLOAD_SOURCE_LAST_ENTRY);
}
-bool ShouldShowInShelf(content::DownloadItem* item) {
- ShowInShelfData* data =
- static_cast<ShowInShelfData*>(item->GetUserData(kShowInShelfKey));
- return !data || data->should_show();
-}
-
-void SetShouldShowInShelf(content::DownloadItem* item, bool should_show) {
- item->SetUserData(kShowInShelfKey, new ShowInShelfData(should_show));
-}
-
} // namespace download_util

Powered by Google App Engine
This is Rietveld 408576698