Refactor FileIO to the new design

content/public/renderer/renderer_ppapi_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDERER_PPAPI_HOST_H_
 #define CONTENT_PUBLIC_RENDERER_RENDERER_PPAPI_HOST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/platform_file.h"
 #include "content/common/content_export.h"
@@ skipping 22 matching lines @@
 class PluginInstance;
 }
 }
 
 namespace WebKit {
 class WebPluginContainer;
 }
 
 namespace webkit {
 namespace ppapi {
+class PluginDelegate;
 class PluginInstance;
 class PluginModule;
 }
 }
 
 namespace content {
 
 class RenderView;
 
 // Interface that allows components in the embedder app to talk to the
@@ skipping 20 matching lines @@
 
   // Returns true if the given PP_Instance is valid and belongs to the
   // plugin associated with this host.
   virtual bool IsValidInstance(PP_Instance instance) const = 0;
 
   // Returns the PluginInstance for the given PP_Instance, or NULL if the
   // PP_Instance is invalid.
   virtual webkit::ppapi::PluginInstance* GetPluginInstance(
       PP_Instance instance) const = 0;
 
+  // Returns the PluginDelegate for the given plugin instance, or NULL if the

[raymes, 2012/11/26 22:30:54]

I would change "plugin instance" -> "PP_Instance" in order not to confuse it
with a PluginInstance.

[victorhsieh, 2012/11/27 09:44:42]

Deleted

+  // instance is invalid.
+  virtual webkit::ppapi::PluginDelegate* GetDelegateForInstance(

[raymes, 2012/11/27 06:54:28]

The plugin delegate shouldn't be needed for new-style resources. The resource
host should be able to access everything it needs directly (more comments in the
host). I would suggest removing this function. You can still get to the delegate
if needed via the plugininstance.

[victorhsieh, 2012/11/27 09:44:42]

Done.

+      PP_Instance instance) const = 0;
+
   // Returns the RenderView for the given plugin instance, or NULL if the
   // instance is invalid.
   virtual RenderView* GetRenderViewForInstance(PP_Instance instance) const = 0;
 
   // Returns the WebPluginContainer for the given plugin instance, or NULL if
   // the instance is invalid.
   virtual WebKit::WebPluginContainer* GetContainerForInstance(
       PP_Instance instance) const = 0;
 
   // Returns true if the given instance is considered to be currently
@@ skipping 26 matching lines @@
       base::PlatformFile handle,
       bool should_close_source) = 0;
 
  protected:
   virtual ~RendererPpapiHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDERER_PPAPI_HOST_H_
-