Issue 11419067: Revert "Drastically reduce the number of created strings in d8."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419067: Revert "Drastically reduce the number of created strings in d8." (Closed)

Created:
8 years, 1 month ago by Sven Panne

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Drastically reduce the number of created strings in d8." This reverts commit 2fc4424b00296cc06d6f7eb4bf31ec9c3d6be68a. Even symbols shouldn't be shared across Isolates. The CL has to be reworked to use a (Isolate,C-string)->v8-symbol mapping. Slowly approaching Chrome... :-/ Committed: https://code.google.com/p/v8/source/detail?r=12999

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -113 lines)			Patch
	M	src/d8.cc	View		24 chunks	+88 lines, -113 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM (rubber-stamped).

Expand Messages | Collapse Messages