Issue 11419038: Allow anyone to update .gitignore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419038: Allow anyone to update .gitignore. (Closed)

Created:
8 years, 1 month ago by Torne

Modified:
8 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow anyone to update .gitignore. This needs to be updated fairly frequently and it should be fine to let everyone do it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168221

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Torne

Hi Ben, I was about to land a .gitignore change and couldn't, so I'm sending ...

8 years, 1 month ago (2012-11-16 14:09:40 UTC) #1

Ben Goodger (Google)

8 years, 1 month ago (2012-11-16 16:31:02 UTC) #2

lgtm


On Fri, Nov 16, 2012 at 6:09 AM, <torne@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Hi Ben, I was about to land a .gitignore change and couldn't, so I'm
> sending you
> this rather than the original CL :)
>
> Description:
> Allow anyone to update .gitignore.
>
> This needs to be updated fairly frequently and it should be fine to let
> everyone do it.
>
> BUG=
>
>
> Please review this at
https://codereview.chromium.**org/11419038/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M OWNERS
>
>
> Index: OWNERS
> diff --git a/OWNERS b/OWNERS
> index 1ef6c1883ea40ea0df37d93819ee30**0f9e2a026a..**
> 1e6d2d443825df05ba05c93ba21b2e**70fd1786b8 100644
> --- a/OWNERS
> +++ b/OWNERS
> @@ -1,5 +1,6 @@
>  darin@chromium.org
>  ben@chromium.org
> +per-file .gitignore=*
>  per-file DEPS=*
>  per-file AUTHORS=*
>  per-file WATCHLISTS=*
>
>
>

Expand Messages | Collapse Messages