Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 11419032: Switch libraries to using new tags. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Missing base files #

Patch Set 3 : Changed . to _. Merged to head. #

Patch Set 4 : Trying to upload base files again #

Patch Set 5 : Merged to head #

Patch Set 6 : Fix problem with special handling of mirrors. #

Patch Set 7 : Updated to tip of tree. Changed library names to dart.x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -1233 lines) Patch
M runtime/lib/mirrors_sources.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/mirrors.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/arrays.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/collection.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/collections.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/maps.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/bool.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/collection.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/comparable.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/core.dart View 3 4 5 6 1 chunk +38 lines, -38 lines 0 comments Download
M sdk/lib/core/date.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/double.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/duration.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/errors.dart View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/core/exceptions.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/expando.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/expect.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/function.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/future.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/future_impl.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/hashable.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/identical.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/int.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/invocation_mirror.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/iterable.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/iterator.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/list.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/map.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/num.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/object.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/options.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/pattern.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/print.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/queue.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/regexp.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/sequences.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/set.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/sort.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/stopwatch.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/string.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/string_buffer.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/strings.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/type.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/crypto/crypto.dart View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M sdk/lib/crypto/crypto_utils.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/crypto/hash_utils.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/crypto/hmac.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/crypto/md5.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/crypto/sha1.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/crypto/sha256.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 4 5 6 20 chunks +0 lines, -356 lines 0 comments Download
M sdk/lib/html/doc/html.dartdoc View 1 2 3 4 5 6 1 chunk +13 lines, -13 lines 0 comments Download
M sdk/lib/io/base64.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/buffer_list.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/chunked_stream.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/common.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/directory.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/eventhandler.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/file.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/http.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/http_session.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/http_utils.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/input_stream.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/io.dart View 1 2 3 4 5 6 1 chunk +42 lines, -42 lines 0 comments Download
sdk/lib/io/list_stream.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
sdk/lib/io/list_stream_impl.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/mime_multipart_parser.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/output_stream.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/path.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/path_impl.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/platform.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/process.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/socket.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/socket_stream_impl.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/stream_util.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/string_stream.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/timer_impl.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/websocket.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/isolate/base.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/isolate/isolate.dart View 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/isolate/timer.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/json/json.dart View 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/math/base.dart View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/math/math.dart View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/math/random.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/mirrors/mirror_classes.dart View 1 2 3 4 5 6 2 chunks +3 lines, -4 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 2 3 4 5 6 1 chunk +2 lines, -738 lines 0 comments Download
M sdk/lib/scalarlist/byte_arrays.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/scalarlist/scalarlist.dart View 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/uri/encode_decode.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/uri/helpers.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/uri/uri.dart View 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/utf/utf.dart View 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/utf/utf16.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/utf/utf32.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/utf/utf8.dart View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/utf/utf_core.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lasse Reichstein Nielsen
This change makes the VM fail to build. Does it not support "part of" in ...
8 years, 1 month ago (2012-11-16 07:19:23 UTC) #1
sra1
On 2012/11/16 07:19:23, Lasse Reichstein Nielsen wrote: > This change makes the VM fail to ...
8 years, 1 month ago (2012-11-16 07:37:26 UTC) #2
Lasse Reichstein Nielsen
Doh, no, I just mistook your username for someone on the VM team, sorry :)
8 years, 1 month ago (2012-11-16 13:10:13 UTC) #3
floitsch
LGTM.
8 years, 1 month ago (2012-11-20 18:32:49 UTC) #4
regis
I just noticed that I am a reviewer. Sorry, but I am not familiar with ...
8 years, 1 month ago (2012-11-20 19:05:01 UTC) #5
hausner
The VM does not support library names with periods. Can you temporarily eliminate the periods?
8 years, 1 month ago (2012-11-20 19:22:13 UTC) #6
Lasse Reichstein Nielsen
I'll make them underscores for now.
8 years, 1 month ago (2012-11-21 11:03:11 UTC) #7
hausner
LGTM
8 years, 1 month ago (2012-11-21 17:13:30 UTC) #8
Lasse Reichstein Nielsen
Hmm, that's still not sufficient. I get the following error when building the VM: ---- ...
8 years, 1 month ago (2012-11-22 09:26:53 UTC) #9
hausner
Ivan says he'll take a look at the source file concatenation issue.
8 years ago (2012-11-26 17:00:04 UTC) #10
Ivan Posva
8 years ago (2012-11-26 19:13:09 UTC) #11
I'll update the generation scripts to pull the "part of  " from the generated
sources. Currently all of the sources for the included libraries are collected
directly into the library, so a "part of" directive is not needed.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698