Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: runtime/bin/file_macos.cc

Issue 11419008: Added O_CLOEXEC to the flags parameter of open() calls (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/file_linux.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/file.h" 5 #include "bin/file.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #include <sys/stat.h> 9 #include <sys/stat.h>
10 #include <unistd.h> 10 #include <unistd.h>
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 return NULL; 109 return NULL;
110 } 110 }
111 } 111 }
112 int flags = O_RDONLY; 112 int flags = O_RDONLY;
113 if ((mode & kWrite) != 0) { 113 if ((mode & kWrite) != 0) {
114 flags = (O_RDWR | O_CREAT); 114 flags = (O_RDWR | O_CREAT);
115 } 115 }
116 if ((mode & kTruncate) != 0) { 116 if ((mode & kTruncate) != 0) {
117 flags = flags | O_TRUNC; 117 flags = flags | O_TRUNC;
118 } 118 }
119 flags |= O_CLOEXEC;
119 int fd = TEMP_FAILURE_RETRY(open(name, flags, 0666)); 120 int fd = TEMP_FAILURE_RETRY(open(name, flags, 0666));
120 if (fd < 0) { 121 if (fd < 0) {
121 return NULL; 122 return NULL;
122 } 123 }
123 if (((mode & kWrite) != 0) && ((mode & kTruncate) == 0)) { 124 if (((mode & kWrite) != 0) && ((mode & kTruncate) == 0)) {
124 int position = TEMP_FAILURE_RETRY(lseek(fd, 0, SEEK_END)); 125 int position = TEMP_FAILURE_RETRY(lseek(fd, 0, SEEK_END));
125 if (position < 0) { 126 if (position < 0) {
126 return NULL; 127 return NULL;
127 } 128 }
128 } 129 }
(...skipping 11 matching lines...) Expand all
140 struct stat st; 141 struct stat st;
141 if (TEMP_FAILURE_RETRY(stat(name, &st)) == 0) { 142 if (TEMP_FAILURE_RETRY(stat(name, &st)) == 0) {
142 return S_ISREG(st.st_mode); 143 return S_ISREG(st.st_mode);
143 } else { 144 } else {
144 return false; 145 return false;
145 } 146 }
146 } 147 }
147 148
148 149
149 bool File::Create(const char* name) { 150 bool File::Create(const char* name) {
150 int fd = TEMP_FAILURE_RETRY(open(name, O_RDONLY | O_CREAT, 0666)); 151 int fd = TEMP_FAILURE_RETRY(open(name, O_RDONLY | O_CREAT | O_CLOEXEC, 0666));
151 if (fd < 0) { 152 if (fd < 0) {
152 return false; 153 return false;
153 } 154 }
154 return (close(fd) == 0); 155 return (close(fd) == 0);
155 } 156 }
156 157
157 158
158 bool File::Delete(const char* name) { 159 bool File::Delete(const char* name) {
159 int status = TEMP_FAILURE_RETRY(remove(name)); 160 int status = TEMP_FAILURE_RETRY(remove(name));
160 if (status == -1) { 161 if (status == -1) {
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 int result = fstat(fd, &buf); 241 int result = fstat(fd, &buf);
241 if (result == -1) { 242 if (result == -1) {
242 FATAL2("Failed stat on file descriptor %d: %s", fd, strerror(errno)); 243 FATAL2("Failed stat on file descriptor %d: %s", fd, strerror(errno));
243 } 244 }
244 if (S_ISCHR(buf.st_mode)) return kTerminal; 245 if (S_ISCHR(buf.st_mode)) return kTerminal;
245 if (S_ISFIFO(buf.st_mode)) return kPipe; 246 if (S_ISFIFO(buf.st_mode)) return kPipe;
246 if (S_ISSOCK(buf.st_mode)) return kSocket; 247 if (S_ISSOCK(buf.st_mode)) return kSocket;
247 if (S_ISREG(buf.st_mode)) return kFile; 248 if (S_ISREG(buf.st_mode)) return kFile;
248 return kOther; 249 return kOther;
249 } 250 }
OLDNEW
« no previous file with comments | « runtime/bin/file_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698