Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: Source/core/fetch/ResourceFetcher.cpp

Issue 1141883003: Enable `as` based priorities for <link rel=preload> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/ResourceFetcher.h ('k') | Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ResourceFetcher.cpp
diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp
index 00385cadfa90d16c809bd32dba09f623d5ecf6c1..1c1110719e9d7d8f56362971ca9e100d90bd31e3 100644
--- a/Source/core/fetch/ResourceFetcher.cpp
+++ b/Source/core/fetch/ResourceFetcher.cpp
@@ -88,6 +88,8 @@ static Resource* createResource(Resource::Type type, const ResourceRequest& requ
return new Resource(request, Resource::LinkPrefetch);
case Resource::LinkSubresource:
return new Resource(request, Resource::LinkSubresource);
+ case Resource::LinkPreload:
+ return new Resource(request, Resource::LinkPreload);
case Resource::ImportResource:
return new RawResource(request, type);
}
@@ -96,8 +98,9 @@ static Resource* createResource(Resource::Type type, const ResourceRequest& requ
return 0;
}
-static ResourceLoadPriority loadPriority(Resource::Type type, const FetchRequest& request)
+ResourceLoadPriority ResourceFetcher::loadPriority(Resource::Type type, const FetchRequest& request)
{
+ // TODO(yoav): Change it here so that priority can be changed even after it was resolved.
if (request.priority() != ResourceLoadPriorityUnresolved)
return request.priority();
@@ -129,6 +132,7 @@ static ResourceLoadPriority loadPriority(Resource::Type type, const FetchRequest
case Resource::SVGDocument:
return ResourceLoadPriorityLow;
case Resource::LinkPrefetch:
+ case Resource::LinkPreload:
return ResourceLoadPriorityVeryLow;
case Resource::LinkSubresource:
return ResourceLoadPriorityLow;
@@ -200,6 +204,10 @@ static WebURLRequest::RequestContext requestContextFromType(bool isMainFrame, Re
return WebURLRequest::RequestContextPrefetch;
case Resource::LinkSubresource:
return WebURLRequest::RequestContextSubresource;
+ case Resource::LinkPreload:
+ // TODO(yoav): We should give preload its own context:
+ // https://github.com/whatwg/fetch/commit/26e5cca8ab5bb4b68a8f238f41dd7364d8c276b3
+ return WebURLRequest::RequestContextSubresource;
case Resource::TextTrack:
return WebURLRequest::RequestContextTrack;
case Resource::SVGDocument:
« no previous file with comments | « Source/core/fetch/ResourceFetcher.h ('k') | Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698