NTP Zombie Code Slayer II: Suggestions Page

chrome/browser/resources/ntp4/page_list_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview PageListView implementation.
  * PageListView manages page list, dot list, switcher buttons and handles apps
  * pages callbacks from backend.
  *
  * Note that you need to have AppLauncherHandler in your WebUI to use this code.
@@ skipping 68 matching lines @@
      */
     tilePages: undefined,
 
     /**
      * A list of all 'apps-page' elements.
      * @type {!NodeList|undefined}
      */
     appsPages: undefined,
 
     /**
-     * The Suggestions page.
-     * @type {!Element|undefined}
-     */
-    suggestionsPage: undefined,
-
-    /**
      * The Most Visited page.
      * @type {!Element|undefined}
      */
     mostVisitedPage: undefined,
 
     /**
      * The 'dots-list' element.
      * @type {!Element|undefined}
      */
     dotList: undefined,
@@ skipping 161 matching lines @@
       }
 
       // Remember special MostVisitedPage.
       if (typeof ntp.MostVisitedPage != 'undefined' &&
           page instanceof ntp.MostVisitedPage) {
         assert(this.tilePages.length == 1,
                'MostVisitedPage should be added as first tile page');
         this.mostVisitedPage = page;
       }
 
-      if (typeof ntp.SuggestionsPage != 'undefined' &&
-          page instanceof ntp.SuggestionsPage) {
-        this.suggestionsPage = page;
-      }
-
       // If we're appending an AppsPage and it's a temporary page, animate it.
       var animate = page instanceof ntp.AppsPage &&
                     page.classList.contains('temporary');
       // Make a deep copy of the dot template to add a new one.
       var newDot = new ntp.NavDot(page, title, titleIsEditable, animate);
       page.navigationDot = newDot;
       this.dotList.insertBefore(newDot,
                                 opt_refNode ? opt_refNode.navigationDot : null);
       // Set a tab index on the first dot.
       if (this.dotList.dots.length == 1)
@@ skipping 238 matching lines @@
 
     /**
      * Invoked whenever the pages in apps-page-list have changed so that
      * the Slider knows about the new elements.
      */
     updateSliderCards: function() {
       var pageNo = Math.max(0, Math.min(this.cardSlider.currentCard,
                                         this.tilePages.length - 1));
       this.cardSlider.setCards(Array.prototype.slice.call(this.tilePages),
                                pageNo);
-      // The shownPage property was potentially saved from a previous webui that
-      // didn't have the same set of pages as the current one. So we cascade
-      // from suggestions, to most visited and then to apps because we can have
-      // an page with apps only (e.g., chrome://apps) or one with only the most
-      // visited, but not one with only suggestions. And we alwayd default to
-      // most visited first when previously shown page is not availabel anymore.
-      // If most visited isn't there either, we go to apps.
-      if (this.shownPage == loadTimeData.getInteger('suggestions_page_id')) {
-        if (this.suggestionsPage)
-          this.cardSlider.selectCardByValue(this.suggestionsPage);
-        else
-          this.shownPage = loadTimeData.getInteger('most_visited_page_id');
-      }
       if (this.shownPage == loadTimeData.getInteger('most_visited_page_id')) {
         if (this.mostVisitedPage)
           this.cardSlider.selectCardByValue(this.mostVisitedPage);
         else
           this.shownPage = loadTimeData.getInteger('apps_page_id');
       }
       if (this.shownPage == loadTimeData.getInteger('apps_page_id') &&
           loadTimeData.getBoolean('showApps')) {
         this.cardSlider.selectCardByValue(
             this.appsPages[Math.min(this.shownPageIndex,
@@ skipping 123 matching lines @@
 
       // Don't change shownPage until startup is done (and page changes actually
       // reflect user actions).
       if (!this.isStartingUp_()) {
         if (page.classList.contains('apps-page')) {
           this.setShownPage_(loadTimeData.getInteger('apps_page_id'),
                              this.getAppsPageIndex(page));
         } else if (page.classList.contains('most-visited-page')) {
           this.setShownPage_(
               loadTimeData.getInteger('most_visited_page_id'), 0);
-        } else if (page.classList.contains('suggestions-page')) {
-          this.setShownPage_(loadTimeData.getInteger('suggestions_page_id'), 0);
         } else {
           console.error('unknown page selected');
         }
       }
 
       // Update the active dot
       var curDot = this.dotList.getElementsByClassName('selected')[0];
       if (curDot)
         curDot.classList.remove('selected');
       page.navigationDot.classList.add('selected');
@@ skipping 130 matching lines @@
       if (page.navigationDot)
         page.navigationDot.remove(opt_animate);
       this.cardSlider.removeCard(page);
     },
   };
 
   return {
     PageListView: PageListView
   };
 });