NTP Zombie Code Slayer II: Suggestions Page

NTP Zombie Code Slayer II: Suggestions Page

It doesn't seem like the suggestions page has been used in a while.

There's a bunch of code that says:

  if (IsSuggestionsPageEnabled()) {
    ...
  }

But the implementation of the feature switching method is:

  bool IsSuggestionsPageEnabled() {
    return false;  // Maybe we'll use this someday.
  }

We shouldn't bloat the binary for a "maybe we'll use it later".

BUG=329637
R=estade@chromium.org

Committed: https://crrev.com/08d5a2ecdfffa9ed4fcc7b43a774e75748f19033
Cr-Commit-Position: refs/heads/master@{#330172}

[Dan Beam, 2015-05-14 23:52:44]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-05-15 00:00:22]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2015-05-15 00:12:18]

Patchset #1 (id:40001) has been deleted

[Dan Beam, 2015-05-15 00:30:27]

Patchset #1 (id:60001) has been deleted

[Dan Beam, 2015-05-15 00:35:58]

https://codereview.chromium.org/1141843004/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/ntp/new_tab_page_handler.h (left):

https://codereview.chromium.org/1141843004/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/ntp/new_tab_page_handler.h:76: BOOKMARKS_PAGE_ID = 3 <<
kPageIdOffset,
also lulz

[Dan Beam, 2015-05-15 06:12:43]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-15 06:13:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141843004/80001

[commit-bot: I haz the power, 2015-05-15 07:02:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 07:02:22]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2015-05-15 18:24:11]

dbeam@chromium.org changed reviewers:
+ thestig@chromium.org

[Dan Beam, 2015-05-15 18:24:11]

+thestig@ for chrome/browser/browser_resources.grd

[Evan Stade, 2015-05-15 18:36:21]

JENGA

lgtm

[Lei Zhang, 2015-05-15 19:37:16]

lgtm

[Dan Beam, 2015-05-15 19:41:11]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-05-15 19:41:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141843004/100001

[commit-bot: I haz the power, 2015-05-15 19:46:58]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2015-05-15 19:47:46]

Patchset 2 (id:??) landed as
https://crrev.com/08d5a2ecdfffa9ed4fcc7b43a774e75748f19033
Cr-Commit-Position: refs/heads/master@{#330172}