Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: tools/telemetry/telemetry/core/backends/android_app_backend.py

Issue 1141833003: [Android] Remove adb_commands from telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (last?) rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/android_app_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/android_app_backend.py b/tools/telemetry/telemetry/core/backends/android_app_backend.py
index b2c56f238be9c456a707758936a00672b5320546..c0654eb02b012300cbbc376a98b171a3f7481d4d 100644
--- a/tools/telemetry/telemetry/core/backends/android_app_backend.py
+++ b/tools/telemetry/telemetry/core/backends/android_app_backend.py
@@ -24,8 +24,8 @@ class AndroidAppBackend(app_backend.AppBackend):
self._existing_processes_by_pid = {}
@property
- def _adb(self):
- return self.platform_backend.adb
+ def _device(self):
+ return self.platform_backend.device
def _IsAppReady(self):
if self._is_app_ready_predicate is None:
@@ -42,10 +42,10 @@ class AndroidAppBackend(app_backend.AppBackend):
backend_settings = android_browser_backend_settings.WebviewBackendSettings(
'android-webview')
with android_command_line_backend.SetUpCommandLineFlags(
- self._adb, backend_settings, webview_startup_args):
+ self._device, backend_settings, webview_startup_args):
# TODO(slamm): check if can use "blocking=True" instead of needing to
# sleep. If "blocking=True" does not work, switch sleep to "ps" check.
- self._adb.device().StartActivity(self._start_intent, blocking=False)
+ self._device.StartActivity(self._start_intent, blocking=False)
util.WaitFor(self._IsAppReady, timeout=60)
self._is_running = True

Powered by Google App Engine
This is Rietveld 408576698