app_list: Improve initial icon loading.

ash/wm/app_list_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/app_list_controller.h"
 
 #include "ash/launcher/launcher.h"
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
@@ skipping 135 matching lines @@
 
 aura::Window* AppListController::GetWindow() {
   return is_visible_ && view_ ? view_->GetWidget()->GetNativeWindow() : NULL;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListController, private:
 
 void AppListController::SetView(app_list::AppListView* view) {
   DCHECK(view_ == NULL);
+  DCHECK(is_visible_);
 
-  if (is_visible_) {
-    view_ = view;
-    views::Widget* widget = view_->GetWidget();
-    widget->AddObserver(this);
-    Shell::GetInstance()->AddPreTargetHandler(this);
-    Launcher::ForWindow(GetWindow())->AddIconObserver(this);
-    widget->GetNativeView()->GetRootWindow()->AddRootWindowObserver(this);
-    aura::client::GetFocusClient(widget->GetNativeView())->AddObserver(this);
-    widget->SetOpacity(0);
-    ScheduleAnimation();
+  view_ = view;
+  views::Widget* widget = view_->GetWidget();
+  widget->AddObserver(this);
+  Shell::GetInstance()->AddPreTargetHandler(this);
+  Launcher::ForWindow(GetWindow())->AddIconObserver(this);
+  widget->GetNativeView()->GetRootWindow()->AddRootWindowObserver(this);
+  aura::client::GetFocusClient(widget->GetNativeView())->AddObserver(this);
 
-    view_->GetWidget()->Show();
-  } else {
-    view->GetWidget()->Close();
-  }
+  view_->ShowWhenReady();
 }
 
 void AppListController::ResetView() {
   if (!view_)
     return;
 
   views::Widget* widget = view_->GetWidget();
   widget->RemoveObserver(this);
   GetLayer(widget)->GetAnimator()->RemoveObserver(this);
   Shell::GetInstance()->RemovePreTargetHandler(this);
@@ skipping 174 matching lines @@
     should_snap_back_ = false;
     ui::ScopedLayerAnimationSettings animation(widget_animator);
     animation.SetTransitionDuration(base::TimeDelta::FromMilliseconds(
         app_list::kOverscrollPageTransitionDurationMs));
     widget->SetBounds(view_bounds_);
   }
 }
 
 }  // namespace internal
 }  // namespace ash