Issue 11418310: Linux: update protoc wrapper to allow building with system protobuf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418310: Linux: update protoc wrapper to allow building with system protobuf. (Closed)

Created:
8 years ago by Paweł Hajdan Jr.

Modified:
8 years ago

Reviewers:
agl

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Linux: update protoc wrapper to allow building with system protobuf. Now when using system protobuf the wrapper copies all relevant .proto files to a temporary directory and removes parts not supported by system protobuf. No rewriting is done when using bundled protobuf (default). BUG=157155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171015

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -9 lines)			Patch
	M	build/protoc.gypi	View		1 chunk	+5 lines, -4 lines	0 comments	Download
	M	tools/protoc_wrapper/protoc_wrapper.py	View	1	3 chunks	+54 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

lgtm https://codereview.chromium.org/11418310/diff/1/tools/protoc_wrapper/protoc_wrapper.py File tools/protoc_wrapper/protoc_wrapper.py (right): https://codereview.chromium.org/11418310/diff/1/tools/protoc_wrapper/protoc_wrapper.py#newcode6 tools/protoc_wrapper/protoc_wrapper.py:6: """A simple wrapper for protoc to add includes ...

8 years ago (2012-12-04 17:20:45 UTC) #2

Paweł Hajdan Jr.

8 years ago (2012-12-04 18:01:51 UTC) #3

https://codereview.chromium.org/11418310/diff/1/tools/protoc_wrapper/protoc_w...
File tools/protoc_wrapper/protoc_wrapper.py (right):

https://codereview.chromium.org/11418310/diff/1/tools/protoc_wrapper/protoc_w...
tools/protoc_wrapper/protoc_wrapper.py:6: """A simple wrapper for protoc to add
includes in generated cpp headers."""
On 2012/12/04 17:20:45, agl wrote:
> This comment may need updating to reflect the additional behaviour.

Done.

Expand Messages | Collapse Messages