Issue 11418304: Revert 170795

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418304: Revert 170795 (Closed)

Created:
8 years ago by sail

Modified:
8 years ago

Reviewers:
sail

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 170795 The ConstrainedWindowMacTest.ShowInUninitializedTab was failing on some bots. http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/78878/steps/browser_tests/logs/stdio > Fix showing constrained window for uninitialized tabs > > If a tab is added without being shown then the associated tab view for the web content will not be created yet. > > When a constrained window is added to that tab the window never gets shown. > > To fix this I've changed ConstrainedWindowMac2 to reshow the window once the web contents becomes visible. > > BUG=163778 > TEST=Reproduced bug 163778 and verified that my patch fixes it. > Verified that ConstrainedWindowMacTest.ShowInUninitializedTab fails without my patch and passes with it. > > > Review URL: https://chromiumcodereview.appspot.com/11419277 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170903

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -77 lines)			Patch
M	chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.h	View	4 chunks	+1 line, -15 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.mm	View	5 chunks	+5 lines, -31 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm	View	3 chunks	+0 lines, -31 lines	0 comments	Download

Total messages: 1 (0 generated)