net/ftp/ftp_directory_listing_parser_netware.cc - Issue 11418296: FTP: misc fixes resulting from my testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_parser_netware.cc

Issue 11418296: FTP: misc fixes resulting from my testing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fixes Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_directory_listing_parser_netware.cc

diff --git a/net/ftp/ftp_directory_listing_parser_netware.cc b/net/ftp/ftp_directory_listing_parser_netware.cc

index 1e8c80e357f82bd1b4b1fbef3618ea759d6cea14..5a9fcfc913a0eff4b608a4f61ab5e47a06727781 100644

--- a/net/ftp/ftp_directory_listing_parser_netware.cc

+++ b/net/ftp/ftp_directory_listing_parser_netware.cc

@@ -49,7 +49,7 @@ bool ParseFtpDirectoryListingNetware(

std::vector<string16> columns;

base::SplitString(CollapseWhitespace(lines[i], false), ' ', &columns);

- if (columns.size() != 8)

+ if (columns.size() < 8)

return false;

FtpDirectoryListingEntry entry;

@@ -83,7 +83,7 @@ bool ParseFtpDirectoryListingNetware(

return false;

}

- entry.name = columns[7];

+ entry.name = FtpUtil::GetStringPartAfterColumns(lines[i], 7);

entries->push_back(entry);

}