Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields.

content/renderer/renderer_date_time_picker.cc

Index: content/renderer/renderer_date_time_picker.cc
diff --git a/content/renderer/renderer_date_time_picker.cc b/content/renderer/renderer_date_time_picker.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b922bc86c5bc09e566a7e088d9021e549a785828
--- /dev/null
+++ b/content/renderer/renderer_date_time_picker.cc
@@ -0,0 +1,78 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/renderer_date_time_picker.h"
+
+#include "content/common/view_messages.h"
+#include "content/renderer/render_view_impl.h"
+
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeChooserCompletion.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeChooserParams.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeInputType.h"
+
+namespace content {
+
+using WebKit::WebString;
+
+RendererDateTimePicker::RendererDateTimePicker(
+    RenderViewImpl* sender,
+    const WebKit::WebDateTimeChooserParams& params,
+    WebKit::WebDateTimeChooserCompletion* completion)
+    : RenderViewObserver(sender),
+      chooser_params_(params),
+      chooser_completion_(completion) {
+}
+
+RendererDateTimePicker::~RendererDateTimePicker() {
+}
+
+static ui::TextInputType ExtractType(
+    const WebKit::WebDateTimeChooserParams& source) {
+
+  if (source.type == WebKit::WebDateTimeInputTypeDate)
+    return ui::TEXT_INPUT_TYPE_DATE;
+  if (source.type == WebKit::WebDateTimeInputTypeDateTime)
+    return ui::TEXT_INPUT_TYPE_DATE_TIME;
+  if (source.type == WebKit::WebDateTimeInputTypeDateTimeLocal)
+    return ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL;
+  if (source.type == WebKit::WebDateTimeInputTypeMonth)
+    return ui::TEXT_INPUT_TYPE_MONTH;
+  if (source.type == WebKit::WebDateTimeInputTypeTime)
+    return ui::TEXT_INPUT_TYPE_TIME;
+  if (source.type == WebKit::WebDateTimeInputTypeWeek)
+    return ui::TEXT_INPUT_TYPE_WEEK;
+  return ui::TEXT_INPUT_TYPE_NONE;
+}
+
+bool RendererDateTimePicker::Open() {
+  ViewHostMsg_TextInputState_Params p;
+  p.type = ExtractType(chooser_params_);
+  p.value = chooser_params_.currentValue.utf8();
+  p.show_ime_if_needed = true;
+  Send(new ViewHostMsg_TextInputStateChanged(routing_id(), p));

[bulach, 2012/12/07 18:10:13]

since it's changing this anyways, why not go ahead and introduce a new message
for this?

[Miguel Garcia, 2012/12/07 19:04:35]

I thought about it but in order to make it work right now I would have to add
yet another handler to render_widget_host_impl.cc  which seems to have a ton
already.

I'd rather do this as as part of splitting dialogs and text from the ime_adapter
and build a new date_time_picker class on the browser side that sends the
message (this is what the color picker does for example). It'd be much more
convenient to do that change on a second cl since it's also going to be fairly
big and I rather not complicate this one more.


On 2012/12/07 18:10:13, bulach wrote:

+  return true;
+}
+
+bool RendererDateTimePicker::OnMessageReceived(
+    const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(RendererDateTimePicker, message)
+    IPC_MESSAGE_HANDLER(ViewMsg_ReplaceDateTime, OnReplaceDateTime)
+    IPC_MESSAGE_HANDLER(ViewMsg_CancelDateTimeDialog, OnCancel)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void RendererDateTimePicker::OnReplaceDateTime(const string16& new_date) {
+  if (chooser_completion_)
+    chooser_completion_->didChooseValue(new_date);
+}
+
+void RendererDateTimePicker::OnCancel() {
+  if (chooser_completion_)
+    chooser_completion_->didCancelChooser();
+}
+
+}  // namespace content