Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: content/renderer/render_view_impl.h

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebaed to include dependent CL Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index bd61b92bb6c5ec2c0e897244368c10488b2bc6fa..b16afa8a50cd5f7f36dae807b7cbc9bfce6e10ac 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -103,6 +103,7 @@ class WebApplicationCacheHostClient;
class WebCompositorOutputSurface;
class WebDOMMessageEvent;
class WebDataSource;
+class WebDateTimeChooserCompletion;
class WebDragData;
class WebGeolocationClient;
class WebGestureEvent;
@@ -124,6 +125,7 @@ class WebTouchEvent;
class WebURLRequest;
class WebUserMediaClient;
struct WebActiveWheelFlingParameters;
+struct WebDateTimeChooserParams;
struct WebFileChooserParams;
struct WebFindOptions;
struct WebMediaPlayerAction;
@@ -156,6 +158,7 @@ class NotificationProvider;
class RenderViewObserver;
class RenderViewTest;
class RendererAccessibility;
+class RendererDateTimePicker;
class RendererPpapiHost;
class RendererWebColorChooserImpl;
class RenderWidgetFullscreenPepper;
@@ -498,6 +501,11 @@ class CONTENT_EXPORT RenderViewImpl
virtual void cancelScheduledContentIntents();
virtual WebKit::WebContentDetectionResult detectContentAround(
const WebKit::WebHitTestResult& touch_hit);
+
+ // Only used on Android since all other platforms implement
+ // date and time input fields using MULTIPLE_FIELDS_UI
+ virtual bool openDateTimeChooser(const WebKit::WebDateTimeChooserParams&,
+ WebKit::WebDateTimeChooserCompletion*);
#endif
// WebKit::WebFrameClient implementation -------------------------------------
@@ -818,7 +826,6 @@ class CONTENT_EXPORT RenderViewImpl
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnHandleKeyboardEvent);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnImeStateChanged);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnNavStateChanged);
- FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnReplaceAll);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnSetTextDirection);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnUpdateWebPreferences);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, SendSwapOutACK);
@@ -960,7 +967,6 @@ class CONTENT_EXPORT RenderViewImpl
void OnReleaseDisambiguationPopupDIB(TransportDIB::Handle dib_handle);
void OnReloadFrame();
void OnReplace(const string16& text);
- void OnReplaceAll(const string16& text);
void OnResetPageEncodingToDefault();
void OnScriptEvalRequest(const string16& frame_xpath,
const string16& jscript,
@@ -1445,6 +1451,9 @@ class CONTENT_EXPORT RenderViewImpl
// The active find-in-page match ordinal during synchronous requests.
// Needed to be remembered across WebKit callbacks.
int synchronous_find_active_match_ordinal_;
+
+ // A date/time picker object for date and time related input elements.
+ scoped_ptr<RendererDateTimePicker> date_time_picker_client_;
#endif
// Misc ----------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698