content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java - Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebaed to include dependent CL Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_android.cc ('K') | « content/content_renderer.gypi ('k') | content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java b/content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java

index 87430ab7e4e4ec0263c38bba0f877b6bf23c54fb..ecb9d4b8a8c5dcde67b9a40e562fe79c8b914d1f 100644

--- a/content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java

+++ b/content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java

@@ -126,7 +126,7 @@ class DateTimePickerDialog extends AlertDialog implements OnClickListener,

@Override

protected void onStop() {

if (Build.VERSION.SDK_INT >= 16) {

- // The default behavior of dialogs changed after JellyBean. In JB

+ // The default behavior of dialogs changed after JellyBean. After JB

bulach 2012/12/07 18:10:13 nit: isn't it "in" rather than "after" ?

Miguel Garcia 2012/12/07 19:04:35 Well that's what I had initially, then Peter asked

// dismissing a dialog (by pressing back for example)

// applies the chosen date. This code is added here so that the custom

// pickers behave the same as the internal DatePickerDialog.