Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/renderer/render_view_impl.h

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index ce73969bdbb9091d2e00114428b8d4c90bfe31f4..931545aaa3b79d3d942d1bc22da323505d302462 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -103,6 +103,8 @@ class WebApplicationCacheHostClient;
class WebCompositorOutputSurface;
class WebDOMMessageEvent;
class WebDataSource;
+class WebDateTimeChooserCompletion;
+class WebDateTimeChooserParams;
class WebDragData;
class WebGeolocationClient;
class WebGestureEvent;
@@ -155,6 +157,7 @@ class NotificationProvider;
class RenderViewObserver;
class RenderViewTest;
class RendererAccessibility;
+class RendererDateTimePicker;
class RendererPpapiHost;
class RendererWebColorChooserImpl;
class RenderWidgetFullscreenPepper;
@@ -494,6 +497,12 @@ class CONTENT_EXPORT RenderViewImpl
virtual void cancelScheduledContentIntents();
virtual WebKit::WebContentDetectionResult detectContentAround(
const WebKit::WebHitTestResult& touch_hit);
+
+ // Only used on Android since all other platforms implement
+ // date and time input fields using
+ // MULTIPLE FIELDS
Avi (use Gerrit) 2012/12/05 16:37:01 Is "MULTIPLE FIELDS" a code thing that you're capi
Miguel Garcia 2012/12/05 17:02:43 Yes, that's how the WebKit feature is called. On
+ virtual bool openDateTimeChooser(const WebKit::WebDateTimeChooserParams&,
+ WebKit::WebDateTimeChooserCompletion*);
#endif
// WebKit::WebFrameClient implementation -------------------------------------
@@ -1435,6 +1444,9 @@ class CONTENT_EXPORT RenderViewImpl
// The active find-in-page match ordinal during synchronous requests.
// Needed to be remembered across WebKit callbacks.
int synchronous_find_active_match_ordinal_;
+
+ // A date/time picker object for date and time related input elements.
+ scoped_ptr<RendererDateTimePicker> date_time_picker_client_;
#endif
// Misc ----------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698