Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: content/renderer/render_view_impl.cc

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index b56a17eb6b246ed3da4a9dcc1eb18b42a781c1c4..bc0275bf49162f464751b0724426d4c592e84312 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -97,6 +97,7 @@
#include "content/renderer/renderer_accessibility.h"
#include "content/renderer/renderer_accessibility_complete.h"
#include "content/renderer/renderer_accessibility_focus_only.h"
+#include "content/renderer/renderer_date_time_picker.h"
#include "content/renderer/renderer_webapplicationcachehost_impl.h"
#include "content/renderer/renderer_webcolorchooser_impl.h"
#include "content/renderer/speech_recognition_dispatcher.h"
@@ -123,6 +124,8 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDOMEvent.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDOMMessageEvent.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDataSource.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeChooserCompletion.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeChooserParams.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebElement.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFileChooserParams.h"
@@ -921,7 +924,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_Replace, OnReplace)
IPC_MESSAGE_HANDLER(ViewMsg_Delete, OnDelete)
IPC_MESSAGE_HANDLER(ViewMsg_SelectAll, OnSelectAll)
- IPC_MESSAGE_HANDLER(ViewMsg_ReplaceAll, OnReplaceAll)
IPC_MESSAGE_HANDLER(ViewMsg_Unselect, OnUnselect)
IPC_MESSAGE_HANDLER(ViewMsg_SetEditableSelectionOffsets,
OnSetEditableSelectionOffsets)
@@ -1341,15 +1343,6 @@ void RenderViewImpl::OnSelectAll() {
WebString::fromUTF8("SelectAll"));
}
-void RenderViewImpl::OnReplaceAll(const string16& text) {
- WebNode node = GetFocusedNode();
- if (node.isNull() || !IsEditableNode(node))
- return;
-
- OnSelectAll();
- OnReplace(text);
-}
-
void RenderViewImpl::OnUnselect() {
if (!webview())
return;
@@ -6282,6 +6275,15 @@ void RenderViewImpl::LaunchAndroidContentIntent(const GURL& intent,
if (!intent.is_empty())
Send(new ViewHostMsg_StartContentIntent(routing_id_, intent));
}
+
+bool RenderViewImpl::openDateTimeChooser(
+ const WebKit::WebDateTimeChooserParams& params,
+ WebKit::WebDateTimeChooserCompletion* completion) {
+ date_time_picker_client_.reset(
+ new RendererDateTimePicker(this, params, completion));
+ return date_time_picker_client_->Open();
+}
+
#endif
void RenderViewImpl::OnAsyncFileOpened(

Powered by Google App Engine
This is Rietveld 408576698