Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields.

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 1706 matching lines @@
 }
 
 void RenderWidget::set_next_paint_is_restore_ack() {
   next_paint_flags_ |= ViewHostMsg_UpdateRect_Flags::IS_RESTORE_ACK;
 }
 
 void RenderWidget::set_next_paint_is_repaint_ack() {
   next_paint_flags_ |= ViewHostMsg_UpdateRect_Flags::IS_REPAINT_ACK;
 }
 
+static bool IsDateTimeInput(ui::TextInputType type) {
+  return type == ui::TEXT_INPUT_TYPE_DATE
+      || type == ui::TEXT_INPUT_TYPE_DATE_TIME
+      || type == ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL
+      || type == ui::TEXT_INPUT_TYPE_MONTH
+      || type == ui::TEXT_INPUT_TYPE_TIME
+      || type == ui::TEXT_INPUT_TYPE_WEEK;
+}
+
+
 void RenderWidget::UpdateTextInputState(ShowIme show_ime) {
   bool show_ime_if_needed = (show_ime == SHOW_IME_IF_NEEDED);
   if (!show_ime_if_needed && !input_method_is_active_)
     return;
   ui::TextInputType new_type = GetTextInputType();
+  if (IsDateTimeInput(new_type))
+    return; // not handled as text in WebKit

[Peter Beverloo, 2012/12/05 11:57:03]

"not considered as a text input field in WebKit."?

I'm a bit wary about having this early return here. We shouldn't be calling
UpdateTextInputState at all for non-text input fields.

[Miguel Garcia, 2012/12/05 16:23:16]

This is called directly from WebKit (WebViewImpl.cpp) I think it's worth keeping
it for now until we fully split dialogs and text based inputs. 

On 2012/12/05 11:57:03, Peter Beverloo wrote:

+
   WebKit::WebTextInputInfo new_info;
   if (webwidget_)
     new_info = webwidget_->textInputInfo();
 
   bool new_can_compose_inline = CanComposeInline();
 
   // Only sends text input params if they are changed or if the ime should be
   // shown.
   if (show_ime_if_needed || (text_input_type_ != new_type
       || text_input_info_ != new_info
@@ skipping 233 matching lines @@
 
 bool RenderWidget::WebWidgetHandlesCompositorScheduling() const {
   return false;
 }
 
 bool RenderWidget::HasTouchEventHandlersAt(const gfx::Point& point) const {
   return true;
 }
 
 }  // namespace content