Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Side by Side Diff: content/renderer/renderer_date_time_picker_impl.h

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_RENDERER_RENDERER_DATE_TIME_PICKER_IMPL_H_
6 #define CONTENT_RENDERER_RENDERER_DATE_TIME_PICKER_IMPL_H_
7
8 #include "base/basictypes.h"
9 #include "content/public/renderer/render_view_observer.h"
10 #include "ui/base/ime/text_input_type.h"
11
12 namespace WebKit {
13 class WebDateTimeChooserCompletion;
14 class WebDateTimeChooserParams;
15 }
bulach 2012/12/03 20:23:03 nit: // namespace WebKit
Miguel Garcia 2012/12/04 10:40:43 Done.
16
17 namespace content {
18 class RenderViewImpl;
19
20 class RendererDateTimePickerImpl : public RenderViewObserver {
21 public:
22 RendererDateTimePickerImpl(
23 RenderViewImpl* sender,
24 const WebKit::WebDateTimeChooserParams&,
25 WebKit::WebDateTimeChooserCompletion*);
26 virtual ~RendererDateTimePickerImpl();
27
28 bool Open();
29
30 private:
31
bulach 2012/12/03 20:23:03 nit: remove extra \n
Miguel Garcia 2012/12/04 10:40:43 Done.
32 void OnReplaceDateTime(string16 new_date);
bulach 2012/12/03 20:23:03 nit: const string16& ?
Miguel Garcia 2012/12/04 10:40:43 Good point
33 void OnClear();
34
35 // Extract the type of form from the chooser params
36 ui::TextInputType ExtractType(const WebKit::WebDateTimeChooserParams&);
37
38 // RenderViewObserver
39 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
40
41 const WebKit::WebDateTimeChooserParams& chooser_params_;
42 WebKit::WebDateTimeChooserCompletion* chooser_completion_; // Not owned by us
bulach 2012/12/03 20:23:03 nit: \n before DISALLOW_...
Miguel Garcia 2012/12/04 10:40:43 Done.
43 DISALLOW_COPY_AND_ASSIGN(RendererDateTimePickerImpl);
44 };
45
46 } // namespace content
bulach 2012/12/03 20:23:03 nit: \n after this
Miguel Garcia 2012/12/04 10:40:43 Done.
47 #endif // CONTENT_RENDERER_RENDERER_DATE_TIME_PICKER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698