Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields.

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 1705 matching lines @@
 }
 
 void RenderWidget::set_next_paint_is_restore_ack() {
   next_paint_flags_ |= ViewHostMsg_UpdateRect_Flags::IS_RESTORE_ACK;
 }
 
 void RenderWidget::set_next_paint_is_repaint_ack() {
   next_paint_flags_ |= ViewHostMsg_UpdateRect_Flags::IS_REPAINT_ACK;
 }
 
+static bool IsDialogType(ui::TextInputType type) {

[bulach, 2012/12/03 20:23:03]

is this going to hold for all platforms?
I mean, "DialogType" is an implementation detail...
perhaps: "HasTextInputState" would be clearer? also, does it need to have a
OS_ANDROID guard?

[Miguel Garcia, 2012/12/04 10:40:43]

I renamed it to IsDateTimeInput. We should really split the date/time releated
stuff from ime but not in this CL. I added a TODO when initializing IME about
it.

About the guard.I am just following the same pattern as with
UpdateTextInputState I can move both inside an android guard if you prefer.


On 2012/12/03 20:23:03, bulach wrote:

+  return type == ui::TEXT_INPUT_TYPE_DATE
+      || type == ui::TEXT_INPUT_TYPE_DATE_TIME
+      || type == ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL
+      || type == ui::TEXT_INPUT_TYPE_MONTH
+      || type == ui::TEXT_INPUT_TYPE_TIME
+      || type == ui::TEXT_INPUT_TYPE_WEEK;
+}
+
+
 void RenderWidget::UpdateTextInputState(ShowIme show_ime) {
   bool show_ime_if_needed = (show_ime == SHOW_IME_IF_NEEDED);
   if (!show_ime_if_needed && !input_method_is_active_)
     return;
   ui::TextInputType new_type = GetTextInputType();
+  if (IsDialogType(new_type))
+    return; // not handled as text anymore

[bulach, 2012/12/03 20:23:03]

nit: remove the "anymore", won't make much sense in the future ;)

[Miguel Garcia, 2012/12/04 10:40:43]

Done.

+
   WebKit::WebTextInputInfo new_info;
   if (webwidget_)
     new_info = webwidget_->textInputInfo();
 
   bool new_can_compose_inline = CanComposeInline();
 
   // Only sends text input params if they are changed or if the ime should be
   // shown.
   if (show_ime_if_needed || (text_input_type_ != new_type
       || text_input_info_ != new_info
@@ skipping 233 matching lines @@
 
 bool RenderWidget::WebWidgetHandlesCompositorScheduling() const {
   return false;
 }
 
 bool RenderWidget::HasTouchEventHandlersAt(const gfx::Point& point) const {
   return true;
 }
 
 }  // namespace content