Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 11418291: Adding about:flags option to enable guest mode. (Closed)

Created:
8 years ago by jwd
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding about:flags option to enable guest mode. BUG=103846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170954

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jwd
8 years ago (2012-12-03 15:50:17 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/11418291/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/11418291/diff/1/chrome/common/chrome_switches.cc#newcode1339 chrome/common/chrome_switches.cc:1339: const char kEnableDesktopGuestMode[] = "enable-desktop-guest-mode"; Match header file ...
8 years ago (2012-12-03 15:57:42 UTC) #2
jwd
Hey Scott, Would you do an owner review please.
8 years ago (2012-12-03 16:47:04 UTC) #3
jwd
https://codereview.chromium.org/11418291/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/11418291/diff/1/chrome/common/chrome_switches.cc#newcode1339 chrome/common/chrome_switches.cc:1339: const char kEnableDesktopGuestMode[] = "enable-desktop-guest-mode"; On 2012/12/03 15:57:42, Roger ...
8 years ago (2012-12-03 17:40:32 UTC) #4
sky
LGTM
8 years ago (2012-12-03 18:10:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/11418291/6001
8 years ago (2012-12-04 12:58:07 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-04 15:23:34 UTC) #7
Message was sent while issue was closed.
Change committed as 170954

Powered by Google App Engine
This is Rietveld 408576698