Issue 11418256: Add the link to "languages and input settings" into Keyboard settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418256: Add the link to "languages and input settings" into Keyboard settings. (Closed)

Created:
8 years ago by yoshiki

Modified:
8 years ago

Reviewers:
Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add the link to "languages and input settings" into Keyboard settings. BUG=163204 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170706

Patch Set 2 : fix fypo #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/keyboard_overlay.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/keyboard_overlay.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm w/nit https://codereview.chromium.org/11418256/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/11418256/diff/1/chrome/app/chromeos_strings.grdp#newcode2046 chrome/app/chromeos_strings.grdp:2046: desc="The link to open 'Language and input ...

8 years ago (2012-11-30 20:02:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11418256/1006

8 years ago (2012-12-03 02:19:33 UTC) #3

Message was sent while issue was closed.

Change committed as 170706

Expand Messages | Collapse Messages

Issue 11418256: Add the link to "languages and input settings" into Keyboard settings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix fypo #

Messages