Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 11418250: [cc] Track the rendering & painting cost of impl-side painting. (Closed)

Created:
8 years ago by nduca
Modified:
8 years ago
Reviewers:
reveman, google-reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Track the rendering & painting cost of impl-side painting. We record how long the rendering thread takes to render each PicturePile, accumulate in TileManager, and report through LayerTreeHostImpl; telemetry queries this information and dumps the output. BUG=163324 R=reveman TBR=enne Review URL: https://codereview.chromium.org/11434033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170413

Patch Set 1 #

Total comments: 1

Patch Set 2 : use layer_rect #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -6 lines) Patch
M cc/layer_tree_host_impl.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M cc/picture.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + cc/picture_layer_impl.cc.orig View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A cc/picture_layer_impl.cc.rej View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A + cc/picture_layer_impl.h.orig View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M cc/picture_pile_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/picture_pile_impl.cc View 3 chunks +12 lines, -1 line 0 comments Download
M cc/tile_manager.h View 1 2 4 chunks +7 lines, -1 line 0 comments Download
M cc/tile_manager.cc View 1 2 6 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nduca
8 years ago (2012-11-29 23:54:32 UTC) #1
reveman
lgtm if opaque_layer_rect is what we should use in Picture::Record. https://codereview.chromium.org/11418250/diff/1/cc/picture.cc File cc/picture.cc (right): https://codereview.chromium.org/11418250/diff/1/cc/picture.cc#newcode72 ...
8 years ago (2012-11-30 00:03:29 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-11-30 00:26:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11418250/2002
8 years ago (2012-11-30 00:27:24 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests
8 years ago (2012-11-30 01:54:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11418250/2002
8 years ago (2012-11-30 01:56:58 UTC) #6
commit-bot: I haz the power
Failed to apply patch for cc/tile_manager.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years ago (2012-11-30 01:57:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11418250/10002
8 years ago (2012-11-30 02:00:05 UTC) #8
commit-bot: I haz the power
8 years ago (2012-11-30 03:01:05 UTC) #9
Retried try job too often on win_rel for step(s) interactive_ui_tests

Powered by Google App Engine
This is Rietveld 408576698