alternate ntp: implement right-aligned search token

chrome/browser/ui/views/location_bar/location_bar_layout.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_LAYOUT_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_LAYOUT_H_
 
 #include "base/memory/scoped_vector.h"
 
 namespace gfx {
 class Rect;
 }
 
 namespace views {
 class View;
 }
 
 struct LocationBarDecoration;
 
 // Helper class used to layout a list of decorations inside the omnibox.
 class LocationBarLayout {
 
  public:
   enum Position {
     LEFT_EDGE = 0,
     RIGHT_EDGE,
   };
 
+  enum Separator {

[beaudoin, 2013/01/09 20:36:52]

Should probably be SeparatorPosition

[kuan, 2013/01/11 21:21:20]

removed based on new design.

+    SEPARATOR_NONE = 0,
+    // For LTR, separator is visually before decoration for LEFT_EDGE and after
+    // decoration for RIGHT_EDGE.

[beaudoin, 2013/01/09 20:36:52]

I would rephrase the comment:
SEPARATOR_BEFORE places the separator to the left of LEFT_EDGE decorations and
to the right of RIGHT_EDGE decorations. 

[kuan, 2013/01/11 21:21:20]

ditto.

+    SEPARATOR_BEFORE,
+    // For LTR, separator is visually after decoration for LEFT_EDGE and before
+    // decoration for RIGHT_EDGE.

[beaudoin, 2013/01/09 20:36:52]

Same here.

[kuan, 2013/01/11 21:21:20]

ditto.

+    SEPARATOR_AFTER,
+  };
+
   LocationBarLayout(Position position,
                     int item_edit_padding,
                     int edge_edit_padding);
   virtual ~LocationBarLayout();
 
   // Add a decoration, specifying:
   // - The |y| position inside its parent;
   // - The |height| in pixel, 0 meaning the preferred height of the |view|;
   // - Whether the decoration should |auto_collapse| if there is no room for it;
   // - The |max_fraction| it can use within the omnibox, or 0 for non-resizable
   //   decorations;
   // - |edge_item_padding|, the padding between the omnibox edge and the item,
   //   if the item is the first one drawn;
   // - |item_padding|, the padding between the previous item and this one;
   // - |builtin_padding|, any padding directly built into the item;
   // - The |view| corresponding to this decoration, a weak pointer.
   // Note that |auto_collapse| can be true if and only if |max_fraction| is 0.
   void AddDecoration(int y,
                      int height,
                      bool auto_collapse,
                      double max_fraction,
                      int edge_item_padding,
                      int item_padding,
                      int builtin_padding,
                      views::View* view);
 
+  // Add a decoration with a separator, the parameters are identical to those
+  // for AddDecoration(), with extra specifications for:
+  // - The |separator| type;
+  // - The |separator_padding| to use between |view| and separator;
+  // - The |separator_height| to use for separator in pixel, 0 meaning final
+  //   height used for |view|;
+  // - The |separator_view| corresponding to the separator for this decoration,
+  //   a weak pointer.
+  void AddDecorationWithSeparator(int y,
+                                  int height,
+                                  bool auto_collapse,
+                                  double max_fraction,
+                                  int edge_item_padding,
+                                  int item_padding,
+                                  int builtin_padding,
+                                  Separator separator,
+                                  int separator_padding,
+                                  int separator_height,
+                                  views::View* view,
+                                  views::View* separator_view);

[beaudoin, 2013/01/09 20:36:52]

I think it would be much simpler to replace the above with:
void AddSeparator(int y, int height, int padding, views::View* separator_view);

This will allow you to drop the Separator enum entirely. To add the separator
before the decoration you would just call:
AddSeparator(...);
AddDecoration(...);

I don't think the separator has to be tied to a specific decoration: since your
SearchTokenView is always the left-most decoration, you just have to check
whether there is something visible to both left and right of the separator.

[kuan, 2013/01/11 21:21:20]

Done.

+
   // Add a non-resizable decoration with standard padding.
   void AddDecoration(int height, int builtin_padding, views::View* view);
 
   // First pass of decoration layout process. Pass the full width of the
   // location bar in |entry_width|. This pass will adjust it to account for
   // non-collapsible and non-resizable decorations.
   void LayoutPass1(int* entry_width);
 
   // Second pass of decoration layout process. Pass the |entry_width| computed
   // by the first pass. This pass will adjust it to account for resizable
   // decorations.
   void LayoutPass2(int* entry_width);
 
   // Third and final pass of decoration layout process. Pass the |bounds|
   // corresponding to the entire space available in the location bar. This pass
   // will update it as decorations are laid out. |available_width| measures the
   // empty space within the location bar, taking the decorations and text into
   // account. |decorations| must always be ordered from the edge of the location
   // bar towards the middle.
   void LayoutPass3(gfx::Rect* bounds, int* available_width);
 
+  // Sets the padding between edit and the decoration beside it.
+  // This value must not be modified after LayoutPass1 has been called.
+  void set_item_edit_padding(int item_edit_padding) {
+    item_edit_padding_ = item_edit_padding;
+  }
+
  private:
+  // Determine if separator of a decoration at |it| should be visible.
+  // |available_width| returns the updated remaining width if separator is
+  // visible.
+  void DetermineSeparatorVisibility(
+      ScopedVector<LocationBarDecoration>::iterator it,
+      bool first_visible,
+      int item_padding,
+      int* available_width);
+
+  // Set bounds of separator is if it's visible, returns true if bounds is set.

[beaudoin, 2013/01/09 20:36:52]

typo: if it is

[kuan, 2013/01/11 21:21:20]

removed, based on new design.

+  // |bounds| returns the updated remaining bounds.
+  bool SetSeparatorBounds(
+      ScopedVector<LocationBarDecoration>::iterator it,
+      int padding,
+      int item_height,
+      gfx::Rect* bounds);
+
   // LEFT_EDGE means decorations are added from left to right and stacked on
   // the left of the omnibox, RIGHT_EDGE means the opposite.
   Position position_;
 
   // The padding between the last decoration and the edit box.
   int item_edit_padding_;
 
   // The padding between the edge and the edit box, if there are no decorations.
   int edge_edit_padding_;
 
   // The list of decorations to layout.
   ScopedVector<LocationBarDecoration> decorations_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarLayout);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_LAYOUT_H_