Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: ui/views/controls/glow_hover_controller.cc

Issue 11418217: Add skia::RefPtr class to wrap ref counted classes from Skia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Drop TNoRef Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/glow_hover_controller.cc
diff --git a/ui/views/controls/glow_hover_controller.cc b/ui/views/controls/glow_hover_controller.cc
index 71785f064395de757a9763ed018b9a807bfe02db..44a4de92ff295257db9d738f6b3844e555cbf78a 100644
--- a/ui/views/controls/glow_hover_controller.cc
+++ b/ui/views/controls/glow_hover_controller.cc
@@ -83,7 +83,7 @@ void GlowHoverController::Draw(gfx::Canvas* canvas,
static_cast<int>(255 * kOpacityScale * animation_.GetCurrentValue());
colors[0] = SkColorSetARGB(hover_alpha, 255, 255, 255);
colors[1] = SkColorSetARGB(0, 255, 255, 255);
- SkShader* shader = SkGradientShader::CreateRadial(center_point,
+ skia::RefPtr<SkShader> shader = SkGradientShader::CreateRadial(center_point,
SkIntToScalar(radius), colors, NULL, 2, SkShader::kClamp_TileMode);
// Shader can end up null when radius = 0.
// If so, this results in default full tab glow behavior.
@@ -91,8 +91,7 @@ void GlowHoverController::Draw(gfx::Canvas* canvas,
SkPaint paint;
paint.setStyle(SkPaint::kFill_Style);
paint.setAntiAlias(true);
- paint.setShader(shader);
- shader->unref();
+ paint.setShader(shader.get());
hover_canvas.DrawRect(gfx::Rect(location_.x() - radius,
location_.y() - radius,
radius * 2, radius * 2), paint);

Powered by Google App Engine
This is Rietveld 408576698