Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: chrome/renderer/safe_browsing/phishing_thumbnailer.cc

Issue 11418217: Add skia::RefPtr class to wrap ref counted classes from Skia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Drop TNoRef Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_thumbnailer.cc
diff --git a/chrome/renderer/safe_browsing/phishing_thumbnailer.cc b/chrome/renderer/safe_browsing/phishing_thumbnailer.cc
index 3b98fea0fd580417e6a50225543891f6d62821e1..aa3f2683d6c79bb2ecdd740c7f4bf923e161c859 100644
--- a/chrome/renderer/safe_browsing/phishing_thumbnailer.cc
+++ b/chrome/renderer/safe_browsing/phishing_thumbnailer.cc
@@ -32,12 +32,12 @@ SkBitmap GrabPhishingThumbnail(content::RenderView* render_view,
}
WebView* view = render_view->GetWebView();
base::TimeTicks beginning_time = base::TimeTicks::Now();
- SkCanvas* canvas = skia::CreatePlatformCanvas(view_size.width(),
- view_size.height(), true, 0,
- skia::RETURN_NULL_ON_FAILURE);
+ skia::RefPtr<SkCanvas> canvas = skia::CreatePlatformCanvas(
+ view_size.width(),
+ view_size.height(), true, 0,
+ skia::RETURN_NULL_ON_FAILURE);
if (!canvas)
return SkBitmap();
- SkAutoUnref au(canvas);
// Make sure we are not using any zoom when we take the snapshot. We will
// restore the previous zoom level after the snapshot is taken.
@@ -51,7 +51,7 @@ SkBitmap GrabPhishingThumbnail(content::RenderView* render_view,
view->mainFrame()->setCanHaveScrollbars(false); // always hide scrollbars.
view->resize(view_size);
view->layout();
- view->paint(webkit_glue::ToWebCanvas(canvas),
+ view->paint(webkit_glue::ToWebCanvas(canvas.get()),
WebRect(0, 0, view_size.width(), view_size.height()));
SkDevice* device = skia::GetTopDevice(*canvas);

Powered by Google App Engine
This is Rietveld 408576698