Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2391)

Unified Diff: chrome/browser/chromeos/login/rounded_rect_painter.cc

Issue 11418217: Add skia::RefPtr class to wrap ref counted classes from Skia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Drop TNoRef Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/rounded_rect_painter.cc
diff --git a/chrome/browser/chromeos/login/rounded_rect_painter.cc b/chrome/browser/chromeos/login/rounded_rect_painter.cc
index 4da680d900766a1b58fc9119ccb050a07c1f9514..d833d72911e71f870d3b80cffc5a2c1040362e14 100644
--- a/chrome/browser/chromeos/login/rounded_rect_painter.cc
+++ b/chrome/browser/chromeos/login/rounded_rect_painter.cc
@@ -38,11 +38,9 @@ void DrawRoundedRect(gfx::Canvas* canvas,
p[0].set(SkIntToScalar(rect.left()), SkIntToScalar(rect.top()));
p[1].set(SkIntToScalar(rect.left()), SkIntToScalar(rect.bottom()));
SkColor colors[2] = { top_color, bottom_color };
- SkShader* s = SkGradientShader::CreateLinear(p, colors, NULL, 2,
- SkShader::kClamp_TileMode, NULL);
- paint.setShader(s);
- // Need to unref shader, otherwise never deleted.
- s->unref();
+ skia::RefPtr<SkShader> s = SkGradientShader::CreateLinear(
+ p, colors, NULL, 2, SkShader::kClamp_TileMode, NULL);
+ paint.setShader(s.get());
} else {
paint.setColor(top_color);
}
@@ -59,9 +57,9 @@ void DrawRoundedRectShadow(gfx::Canvas* canvas,
paint.setFlags(SkPaint::kAntiAlias_Flag);
paint.setStyle(SkPaint::kFill_Style);
paint.setColor(color);
- SkMaskFilter* filter = SkBlurMaskFilter::Create(
+ skia::RefPtr<SkMaskFilter> filter = SkBlurMaskFilter::Create(
shadow / 2, SkBlurMaskFilter::kNormal_BlurStyle);
- paint.setMaskFilter(filter)->unref();
+ paint.setMaskFilter(filter.get());
SkRect inset_rect(rect);
inset_rect.inset(SkIntToScalar(shadow / 2), SkIntToScalar(shadow / 2));
canvas->sk_canvas()->drawRoundRect(

Powered by Google App Engine
This is Rietveld 408576698