Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4012)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.h

Issue 11418200: Setup from settings should allow configuration first (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_handler.h
diff --git a/chrome/browser/ui/webui/sync_setup_handler.h b/chrome/browser/ui/webui/sync_setup_handler.h
index 9838ec8368a4b1ca8073d6c3039b5cc5ac4fcc66..63e3a5a0f73cc147ebc2282e3ac465a5520bcc00 100644
--- a/chrome/browser/ui/webui/sync_setup_handler.h
+++ b/chrome/browser/ui/webui/sync_setup_handler.h
@@ -11,15 +11,21 @@
#include "chrome/browser/signin/signin_tracker.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
#include "chrome/browser/ui/webui/signin/login_ui_service.h"
+#include "content/public/browser/web_contents_observer.h"
class LoginUIService;
class ProfileManager;
class ProfileSyncService;
class SigninManager;
+namespace content {
+class WebContents;
+}
+
class SyncSetupHandler : public options::OptionsPageUIHandler,
public SigninTracker::Observer,
- public LoginUIService::LoginUI {
+ public LoginUIService::LoginUI,
+ public content::WebContentsObserver {
public:
// Constructs a new SyncSetupHandler. |profile_manager| may be NULL.
explicit SyncSetupHandler(ProfileManager* profile_manager);
@@ -39,6 +45,10 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,
virtual void FocusUI() OVERRIDE;
virtual void CloseUI() OVERRIDE;
+ // content::WebContentsObserver implementation.
+ virtual void WebContentsDestroyed(
+ content::WebContents* web_contents) OVERRIDE;
+
static void GetStaticLocalizedValues(
base::DictionaryValue* localized_strings,
content::WebUI* web_ui);
@@ -164,6 +174,10 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,
// Invokes the javascript call to close the setup overlay.
void CloseOverlay();
+ // When using web-flow, closes the Gaia page used to collection user
+ // credentials.
+ void CloseGaiaSigninPage();
+
// Returns true if the given login data is valid, false otherwise. If the
// login data is not valid then on return |error_message| will be set to a
// localized error message. Note, |error_message| must not be NULL.
@@ -201,6 +215,9 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,
// service.
scoped_ptr<base::OneShotTimer<SyncSetupHandler> > backend_start_timer_;
+ // When using web-flow, pointer to the tab that holds the Gaia sign in page.
James Hawkins 2012/12/04 00:14:48 nit: 'weak pointer' I imagine.
Roger Tawa OOO till Jul 10th 2012/12/04 00:36:37 Done.
+ content::WebContents* active_gaia_signin_tab_;
+
DISALLOW_COPY_AND_ASSIGN(SyncSetupHandler);
};

Powered by Google App Engine
This is Rietveld 408576698