Setup from settings should allow configuration first

chrome/browser/ui/sync/one_click_signin_sync_starter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_
 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_
 
 #include <string>
 
 #include "chrome/browser/signin/signin_tracker.h"
 
 class Browser;
 
 // Waits for successful singin notification from the signin manager and then
 // starts the sync machine.  Instances of this class delete themselves once
 // the job is done.
 class OneClickSigninSyncStarter : public SigninTracker::Observer {
  public:
-  enum StartSyncMode {SYNC_WITH_DEFAULT_SETTINGS, CONFIGURE_SYNC_FIRST };
+  enum StartSyncMode {SYNC_WITH_DEFAULT_SETTINGS, CONFIGURE_SYNC_FIRST,

[Andrew T Wilson (Slow), 2012/11/30 16:40:12]

I think we ought to put this enum with one value per line and some documentation
of the settings, now that there are 3 items.

[Roger Tawa OOO till Jul 10th, 2012/12/01 16:09:54]

Done.

+                      SIGNIN_ONLY};
 
   OneClickSigninSyncStarter(Browser* browser,
                             const std::string& session_index,
                             const std::string& email,
                             const std::string& password,
                             StartSyncMode start_mode);
 
  private:
   virtual ~OneClickSigninSyncStarter();
 
   // SigninTracker::Observer override.
   virtual void GaiaCredentialsValid() OVERRIDE;
   virtual void SigninFailed(const GoogleServiceAuthError& error) OVERRIDE;
   virtual void SigninSuccess() OVERRIDE;
 
   Browser* browser_;
   SigninTracker signin_tracker_;
   StartSyncMode start_mode_;
 
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninSyncStarter);
 };
 
 
 #endif  // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_