Setup from settings should allow configuration first

chrome/browser/ui/sync/one_click_signin_sync_starter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
@@ skipping 41 matching lines @@
   ProfileSyncService* profile_sync_service =
       ProfileSyncServiceFactory::GetForProfile(browser_->profile());
   profile_sync_service->SetSetupInProgress(false);
   delete this;
 }
 
 void OneClickSigninSyncStarter::SigninSuccess() {
   ProfileSyncService* profile_sync_service =
       ProfileSyncServiceFactory::GetForProfile(browser_->profile());
 
-  if (start_mode_ == SYNC_WITH_DEFAULT_SETTINGS) {
-    // Just kick off the sync machine, no need to configure it first.
-    profile_sync_service->OnUserChoseDatatypes(true, syncer::ModelTypeSet());
-    profile_sync_service->SetSyncSetupCompleted();
-    profile_sync_service->SetSetupInProgress(false);
-  } else {
-    // Give the user a chance to configure things. We don't clear the
-    // ProfileSyncService::setup_in_progress flag because we don't want sync
-    // to start up until after the configure UI is displayed (the configure UI
-    // will clear the flag when the user is done setting up sync).
-    LoginUIServiceFactory::GetForProfile(browser_->profile())->ShowLoginUI(
-        browser_);
+  switch (start_mode_) {
+    case SYNC_WITH_DEFAULT_SETTINGS:
+      // Just kick off the sync machine, no need to configure it first.
+      profile_sync_service->OnUserChoseDatatypes(true, syncer::ModelTypeSet());
+      profile_sync_service->SetSyncSetupCompleted();
+      profile_sync_service->SetSetupInProgress(false);
+      break;
+    case CONFIGURE_SYNC_FIRST:
+      // Give the user a chance to configure things. We don't clear the
+      // ProfileSyncService::setup_in_progress flag because we don't want sync
+      // to start up until after the configure UI is displayed (the configure UI
+      // will clear the flag when the user is done setting up sync).
+      LoginUIServiceFactory::GetForProfile(browser_->profile())->ShowLoginUI(
+          browser_);
+      break;
+    case SIGNIN_ONLY:
+      // Don't do anything with sync.
+      break;
+    default:
+      NOTREACHED() << "Invalid start_mode=" << start_mode_;
   }
 
   delete this;
 }