cc/math_util.h - Issue 11418197: Move temporary MathUtil wrappers to permanent home in gfx::Transform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/math_util.h

Issue 11418197: Move temporary MathUtil wrappers to permanent home in gfx::Transform (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: patch for landing Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/math_util.h

diff --git a/cc/math_util.h b/cc/math_util.h

index 99ee46cfd8dda88c03f208a72a20945cee72ea67..e3ed2d3f5c8c5f6df38b33a29ceaa9568bc55fa4 100644

--- a/cc/math_util.h

+++ b/cc/math_util.h

@@ -120,11 +120,7 @@ public:

// TODO(shawnsingh, vollick) we should phase out as much as possible of

// these temporary functions, putting functionality into gfx::Transform.

- static bool isBackFaceVisible(const gfx::Transform&);

- static bool isIdentityOrTranslation(const gfx::Transform&);

- static bool hasPerspective(const gfx::Transform&);

static void rotateEulerAngles(gfx::Transform*, double eulerX, double eulerY, double eulerZ);

- static void rotateAxisAngle(gfx::Transform*, double i, double j, double k, double degrees);

static gfx::Transform inverse(const gfx::Transform&);

static gfx::Transform to2dTransform(const gfx::Transform&);

// Note carefully: the args here are labeled as per Webcore indexing conventions.

« no previous file with comments | « cc/layer_tree_host_common_unittest.cc ('k') | cc/math_util.cc » ('j') | no next file with comments »