Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: cc/layer_sorter_unittest.cc

Issue 11418197: Move temporary MathUtil wrappers to permanent home in gfx::Transform (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layer_tree_host_common.cc » ('j') | ui/gfx/transform.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_sorter_unittest.cc
diff --git a/cc/layer_sorter_unittest.cc b/cc/layer_sorter_unittest.cc
index 9b13fce76e1d8805e4b6f611c49dfeb01c69faae..46ad77fa930df491141cb02bf75d4fa3484b9715 100644
--- a/cc/layer_sorter_unittest.cc
+++ b/cc/layer_sorter_unittest.cc
@@ -64,7 +64,7 @@ TEST(LayerSorterTest, RightAngleOverlap)
// Two layers forming a right angle with a perspective viewing transform.
gfx::Transform leftFaceMatrix;
leftFaceMatrix.Translate3d(-1, 0, -5);
- MathUtil::rotateAxisAngle(&leftFaceMatrix, 0, 1, 0, -90);
+ leftFaceMatrix.RotateAbout(gfx::Vector3dF::YAxis(), -90);
leftFaceMatrix.Translate(-1, -1);
LayerShape leftFace(2, 2, perspectiveMatrix * leftFaceMatrix);
gfx::Transform frontFaceMatrix;
@@ -94,7 +94,7 @@ TEST(LayerSorterTest, IntersectingLayerOverlap)
gfx::Transform throughMatrix;
throughMatrix.Translate3d(0, 0, -4);
- MathUtil::rotateAxisAngle(&throughMatrix, 0, 1, 0, 45);
+ throughMatrix.RotateAbout(gfx::Vector3dF(0, 1, 0), 45);
danakj 2012/11/28 00:42:12 yaxis?
throughMatrix.Translate(-1, -1);
LayerShape rotatedFace(2, 2, perspectiveMatrix * throughMatrix);
overlapResult = LayerSorter::checkOverlap(&frontFace, &rotatedFace, zThreshold, weight);
@@ -131,7 +131,7 @@ TEST(LayerSorterTest, LayersAtAngleOverlap)
LayerShape layerB(8, 20, transformB);
gfx::Transform transformC;
- MathUtil::rotateAxisAngle(&transformC, 0, 1, 0, 40);
+ transformC.RotateAbout(gfx::Vector3dF::YAxis(), 40);
transformC.Translate(-4, -10);
LayerShape layerC(8, 20, transformC);
« no previous file with comments | « no previous file | cc/layer_tree_host_common.cc » ('j') | ui/gfx/transform.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698