Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: chrome/test/pyautolib/asan_stub.c

Issue 11418195: Clean up a few -faddress-sanitizer stragglers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | tools/clang/scripts/update.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/asan_stub.c
diff --git a/chrome/test/pyautolib/asan_stub.c b/chrome/test/pyautolib/asan_stub.c
index 4fa4686fa282a8214c00ed98f5ee15a0481b8bd5..0826ef0625fb4647422474e533d38fa33a0717e4 100644
--- a/chrome/test/pyautolib/asan_stub.c
+++ b/chrome/test/pyautolib/asan_stub.c
@@ -21,10 +21,10 @@
//
// Option (2) is not easy because pyautolib uses code from Chrome
// (see chrome_tests.gypi, dependencies for target_name: pyautolib) that
-// has been instrumented with ASAN. So even if we disable -faddress-sanitizer
+// has been instrumented with ASAN. So even if we disable -sanitize=address
// for pyautolib own sources, ASAN instrumentation will creep in from there.
// To avoid ASAN instrumentation, we might force Chrome build to compile all our
-// dependencies one more time without -faddress-sanitizer.
+// dependencies one more time without -fsanitize=address.
//
// Note also that using these empty stubs prevents ASAN from catching bugs in
// Python-pyautolib process. But we do not need it, we are interested in Chrome
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | tools/clang/scripts/update.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698