Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: build/common.gypi

Issue 11418195: Clean up a few -faddress-sanitizer stragglers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0daf4440f775d6bf7e0884519a7593afdfab7f2d..18e4b287915686e38555f0c77795edc17b597dc7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -259,8 +259,8 @@
# Has no effect if 'clang' is not set as well.
'clang_use_chrome_plugins%': 1,
- # Enable building with ASAN (Clang's -faddress-sanitizer option).
- # -faddress-sanitizer only works with clang, but asan=1 implies clang=1
+ # Enable building with ASAN (Clang's -fsanitize=address option).
+ # -fsanitize=address only works with clang, but asan=1 implies clang=1
# See https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer
'asan%': 0,
@@ -3167,7 +3167,7 @@
'-w', # http://crbug.com/162783
],
'ldflags!': [
- '-faddress-sanitizer',
+ '-fsanitize=address',
'-Wl,-z,noexecstack',
'-Wl,--gc-sections',
'-Wl,-O1',
@@ -3301,7 +3301,7 @@
['asan==1', {
'xcode_settings': {
'OTHER_LDFLAGS': [
- '-faddress-sanitizer',
+ '-fsanitize=address',
],
},
}],
« no previous file with comments | « no previous file | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698