Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 11418134: ppapi: Opt-in to receive synthetic mouse events for touch-events. (Closed)

Created:
8 years, 1 month ago by sadrul
Modified:
8 years ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

ppapi: Opt-in to receive synthetic mouse events for touch-events. If a pepper plugin did not opt-in to receive touch-events, then opt-in to receive synthetic mouse-events instead. BUG=138362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170097

Patch Set 1 : . #

Patch Set 2 : self-nit #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 3 4 5 2 chunks +1 line, -8 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
M ppapi/api/ppb_input_event.idl View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M ppapi/c/ppb_input_event.h View 1 2 3 3 chunks +10 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 4 5 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
The corresponding webkit CL is: https://bugs.webkit.org/show_bug.cgi?id=103092
8 years, 1 month ago (2012-11-22 22:40:41 UTC) #1
brettw
We should update the documentation for this event class to state that registering for touch ...
8 years ago (2012-11-27 00:40:33 UTC) #2
sadrul
On 2012/11/27 00:40:33, brettw wrote: > We should update the documentation for this event class ...
8 years ago (2012-11-27 00:53:25 UTC) #3
brettw
LGTM. Sorry, I have no idea about the WebKit side these days.
8 years ago (2012-11-27 05:21:45 UTC) #4
brettw
Oh, can you revert the thunk files with only changed timestamps? There's a bug in ...
8 years ago (2012-11-27 05:22:33 UTC) #5
sadrul
8 years ago (2012-11-27 05:42:40 UTC) #6
On 2012/11/27 05:22:33, brettw wrote:
> Oh, can you revert the thunk files with only changed timestamps? There's a bug
> in the generator that always updates some of those.

Done. Thanks!

Powered by Google App Engine
This is Rietveld 408576698