cc: Increment the ref count when assigning the SkImageFilter

cc/render_pass.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/render_pass.h"
 
 #include "third_party/skia/include/core/SkImageFilter.h"
 
 using WebKit::WebTransformationMatrix;
 
@@ skipping 26 matching lines @@
                     has_occlusion_from_outside_target_surface,
                     filters,
                     filter,
                     background_filters);
   return copy_pass.Pass();
 }
 
 void RenderPass::SetNew(Id id,
                         gfx::Rect output_rect,
                         gfx::RectF damage_rect,
-                        const WebKit::WebTransformationMatrix& transform_to_root_target) {
+                        const WebKit::WebTransformationMatrix& transform_to_root_target,
+                        SkImageFilter* filter) {
   DCHECK_GT(id.layer_id, 0);
   DCHECK_GE(id.index, 0);
 
   this->id = id;
   this->output_rect = output_rect;
   this->damage_rect = damage_rect;
   this->transform_to_root_target = transform_to_root_target;
+  SkRefCnt_SafeAssign(this->filter, filter);

[enne (OOO), 2012/11/21 16:52:02]

What about just making filter an SkRefPtr<SkImageFilter> so you don't have to
remember to un-ref it and it automatically safe assigns?

 
   DCHECK(quad_list.isEmpty());
   DCHECK(shared_quad_state_list.isEmpty());
 }
 
 void RenderPass::SetAll(Id id,
                         gfx::Rect output_rect,
                         gfx::RectF damage_rect,
                         const WebKit::WebTransformationMatrix& transform_to_root_target,
                         bool has_transparent_background,
@@ skipping 13 matching lines @@
       has_occlusion_from_outside_target_surface;
   this->filters = filters;
   SkRefCnt_SafeAssign(this->filter, filter);
   this->background_filters = background_filters;
 
   DCHECK(quad_list.isEmpty());
   DCHECK(shared_quad_state_list.isEmpty());
 }
 
 }  // namespace cc