sdk/lib/_internal/compiler/implementation/lib/js_string.dart - Issue 11418115: Fix Unicode issues in dart2js and dart2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

Issue 11418115: Fix Unicode issues in dart2js and dart2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove accidental test expectation dupe Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_string.dart b/sdk/lib/_internal/compiler/implementation/lib/js_string.dart

index a87c6116302843abcc182ec05127a313a0649b8c..2086cd9aa766749f0b7c4e30ea9a52ef4906b2e1 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_string.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_string.dart

@@ -89,7 +89,7 @@ class JSString implements String {

List<int> get charCodes {

List<int> result = new List<int>(length);

for (int i = 0; i < length; i++) {

- result[i] = charCodeAt(i);

+ result[i] = JS('int', '#.charCodeAt(#)', this, i);

}

return result;

}