Add policy for ash launcher auto-hide behavior

ash/shell.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shell.h"
 
 #include <algorithm>
 #include <string>
 
 #include "ash/accelerators/focus_manager_factory.h"
@@ skipping 674 matching lines @@
 void Shell::SetShelfAutoHideBehavior(ShelfAutoHideBehavior behavior,
                                      aura::RootWindow* root_window) {
   GetRootWindowController(root_window)->SetShelfAutoHideBehavior(behavior);
 }
 
 ShelfAutoHideBehavior Shell::GetShelfAutoHideBehavior(
     aura::RootWindow* root_window) const {
   return GetRootWindowController(root_window)->GetShelfAutoHideBehavior();
 }
 
-bool Shell::IsShelfAutoHideMenuHideChecked(aura::RootWindow* root_window) {
-  return GetRootWindowController(root_window)->GetShelfAutoHideBehavior() ==
-      ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS;
-}

[oshima, 2012/11/26 19:13:00]

Given that this is used in two places, I prefer to keep this.

[bartfab (slow), 2012/11/29 18:25:51]

This is actually not used in production code at all. The only legitimate user
was |ContextMenu|, a part of the ash_shell and thus developer code. You are
right that |LauncherContextMenu| also used to call this method but that was
wrong: Rather than asking the shell, the context menu should ask the
|ChromeLauncherController|. Only the controller knows about prefs and will
always return the current pref value (very important if the pref is being forced
to a certain value by policy).

If you want me to, I can restore this method - but there will be a single user,
in developer code. It would be wrong to have support code only needed for that
one use case in |Shell| IMHO.

[oshima, 2012/11/29 18:43:35]

This is used in launcher_context_menu.cc, and it's production code, isn't it?

[bartfab (slow), 2012/11/29 19:01:10]

As I mentioned above, yes, launcher_context_menu.cc was using this method but
that was wrong. By talking to the shell directly, the context menu was bypassing
the controller, taking away its chance to read the current value from prefs and
prevent any attempts to change it if the value is enforced by policy.

-
-ShelfAutoHideBehavior Shell::GetToggledShelfAutoHideBehavior(
-    aura::RootWindow* root_window) {
-  return GetRootWindowController(root_window)->
-      GetToggledShelfAutoHideBehavior();
-}
-
 void Shell::SetShelfAlignment(ShelfAlignment alignment,
                               aura::RootWindow* root_window) {
   if (GetRootWindowController(root_window)->SetShelfAlignment(alignment))
     FOR_EACH_OBSERVER(ShellObserver, observers_, OnShelfAlignmentChanged());
 }
 
 ShelfAlignment Shell::GetShelfAlignment(aura::RootWindow* root_window) {
   return GetRootWindowController(root_window)->GetShelfAlignment();
 }
 
@@ skipping 142 matching lines @@
 
 bool Shell::CanAcceptEvents() {
   return true;
 }
 
 ui::EventTarget* Shell::GetParentTarget() {
   return NULL;
 }
 
 }  // namespace ash