Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Side by Side Diff: cc/delegated_renderer_layer_impl.cc

Issue 11418108: cc: Make the ScopedPtrVector and ScopedPtrDeque containers act like STL vector and deque. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add DCHECK Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | cc/delegated_renderer_layer_impl_unittest.cc » ('j') | cc/scoped_ptr_deque.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/delegated_renderer_layer_impl.h" 5 #include "cc/delegated_renderer_layer_impl.h"
6 6
7 #include "cc/append_quads_data.h" 7 #include "cc/append_quads_data.h"
8 #include "cc/math_util.h" 8 #include "cc/math_util.h"
9 #include "cc/quad_sink.h" 9 #include "cc/quad_sink.h"
10 #include "cc/render_pass_draw_quad.h" 10 #include "cc/render_pass_draw_quad.h"
(...skipping 11 matching lines...) Expand all
22 clearRenderPasses(); 22 clearRenderPasses();
23 } 23 }
24 24
25 bool DelegatedRendererLayerImpl::descendantDrawsContent() 25 bool DelegatedRendererLayerImpl::descendantDrawsContent()
26 { 26 {
27 // FIXME: This could possibly return false even though there are some 27 // FIXME: This could possibly return false even though there are some
28 // quads present as they could all be from a single layer (or set of 28 // quads present as they could all be from a single layer (or set of
29 // layers without children). If this happens, then make a test that 29 // layers without children). If this happens, then make a test that
30 // ensures the opacity is being changed on quads in the root RenderPass 30 // ensures the opacity is being changed on quads in the root RenderPass
31 // when this layer doesn't own a RenderSurfaceImpl. 31 // when this layer doesn't own a RenderSurfaceImpl.
32 return !m_renderPassesInDrawOrder.isEmpty(); 32 return !m_renderPassesInDrawOrder.empty();
33 } 33 }
34 34
35 bool DelegatedRendererLayerImpl::hasContributingDelegatedRenderPasses() const 35 bool DelegatedRendererLayerImpl::hasContributingDelegatedRenderPasses() const
36 { 36 {
37 // The root RenderPass for the layer is merged with its target 37 // The root RenderPass for the layer is merged with its target
38 // RenderPass in each frame. So we only have extra RenderPasses 38 // RenderPass in each frame. So we only have extra RenderPasses
39 // to merge when we have a non-root RenderPass present. 39 // to merge when we have a non-root RenderPass present.
40 return m_renderPassesInDrawOrder.size() > 1; 40 return m_renderPassesInDrawOrder.size() > 1;
41 } 41 }
42 42
43 void DelegatedRendererLayerImpl::setRenderPasses(ScopedPtrVector<RenderPass>& re nderPassesInDrawOrder) 43 void DelegatedRendererLayerImpl::setRenderPasses(ScopedPtrVector<RenderPass>& re nderPassesInDrawOrder)
44 { 44 {
45 gfx::RectF oldRootDamage; 45 gfx::RectF oldRootDamage;
46 if (!m_renderPassesInDrawOrder.isEmpty()) 46 if (!m_renderPassesInDrawOrder.empty())
47 oldRootDamage = m_renderPassesInDrawOrder.last()->damageRect(); 47 oldRootDamage = m_renderPassesInDrawOrder.back()->damageRect();
48 48
49 clearRenderPasses(); 49 clearRenderPasses();
50 50
51 for (size_t i = 0; i < renderPassesInDrawOrder.size(); ++i) { 51 for (size_t i = 0; i < renderPassesInDrawOrder.size(); ++i) {
52 m_renderPassesIndexById.insert(std::pair<RenderPass::Id, int>(renderPass esInDrawOrder[i]->id(), i)); 52 m_renderPassesIndexById.insert(std::pair<RenderPass::Id, int>(renderPass esInDrawOrder[i]->id(), i));
53 m_renderPassesInDrawOrder.append(renderPassesInDrawOrder.take(i)); 53 m_renderPassesInDrawOrder.push_back(renderPassesInDrawOrder.take(renderP assesInDrawOrder.begin() + i));
54 } 54 }
55 renderPassesInDrawOrder.clear(); 55 renderPassesInDrawOrder.clear();
56 56
57 if (!m_renderPassesInDrawOrder.isEmpty()) { 57 if (!m_renderPassesInDrawOrder.empty()) {
58 gfx::RectF newRootDamage = m_renderPassesInDrawOrder.last()->damageRect( ); 58 gfx::RectF newRootDamage = m_renderPassesInDrawOrder.back()->damageRect( );
59 m_renderPassesInDrawOrder.last()->setDamageRect(gfx::UnionRects(oldRootD amage, newRootDamage)); 59 m_renderPassesInDrawOrder.back()->setDamageRect(gfx::UnionRects(oldRootD amage, newRootDamage));
60 } 60 }
61 } 61 }
62 62
63 void DelegatedRendererLayerImpl::clearRenderPasses() 63 void DelegatedRendererLayerImpl::clearRenderPasses()
64 { 64 {
65 // FIXME: Release the resources back to the nested compositor. 65 // FIXME: Release the resources back to the nested compositor.
66 m_renderPassesIndexById.clear(); 66 m_renderPassesIndexById.clear();
67 m_renderPassesInDrawOrder.clear(); 67 m_renderPassesInDrawOrder.clear();
68 } 68 }
69 69
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 // Don't clash with the RenderPass we generate if we own a RenderSurface Impl. 103 // Don't clash with the RenderPass we generate if we own a RenderSurface Impl.
104 DCHECK(outputRenderPassId.index > 0); 104 DCHECK(outputRenderPassId.index > 0);
105 105
106 renderPassSink.appendRenderPass(m_renderPassesInDrawOrder[i]->copy(outpu tRenderPassId)); 106 renderPassSink.appendRenderPass(m_renderPassesInDrawOrder[i]->copy(outpu tRenderPassId));
107 } 107 }
108 } 108 }
109 109
110 void DelegatedRendererLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData & appendQuadsData) 110 void DelegatedRendererLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData & appendQuadsData)
111 { 111 {
112 if (m_renderPassesInDrawOrder.isEmpty()) 112 if (m_renderPassesInDrawOrder.empty())
113 return; 113 return;
114 114
115 RenderPass::Id targetRenderPassId = appendQuadsData.renderPassId; 115 RenderPass::Id targetRenderPassId = appendQuadsData.renderPassId;
116 116
117 // If the index of the renderPassId is 0, then it is a renderPass generated for a layer 117 // If the index of the renderPassId is 0, then it is a renderPass generated for a layer
118 // in this compositor, not the delegated renderer. Then we want to merge our root renderPass with 118 // in this compositor, not the delegated renderer. Then we want to merge our root renderPass with
119 // the target renderPass. Otherwise, it is some renderPass which we added fr om the delegated 119 // the target renderPass. Otherwise, it is some renderPass which we added fr om the delegated
120 // renderer. 120 // renderer.
121 bool shouldMergeRootRenderPassWithTarget = !targetRenderPassId.index; 121 bool shouldMergeRootRenderPassWithTarget = !targetRenderPassId.index;
122 if (shouldMergeRootRenderPassWithTarget) { 122 if (shouldMergeRootRenderPassWithTarget) {
123 // Verify that the renderPass we are appending to is created our renderT arget. 123 // Verify that the renderPass we are appending to is created our renderT arget.
124 DCHECK(targetRenderPassId.layerId == renderTarget()->id()); 124 DCHECK(targetRenderPassId.layerId == renderTarget()->id());
125 125
126 RenderPass* rootDelegatedRenderPass = m_renderPassesInDrawOrder.last(); 126 RenderPass* rootDelegatedRenderPass = m_renderPassesInDrawOrder.back();
127 appendRenderPassQuads(quadSink, appendQuadsData, rootDelegatedRenderPass ); 127 appendRenderPassQuads(quadSink, appendQuadsData, rootDelegatedRenderPass );
128 } else { 128 } else {
129 // Verify that the renderPass we are appending to was created by us. 129 // Verify that the renderPass we are appending to was created by us.
130 DCHECK(targetRenderPassId.layerId == id()); 130 DCHECK(targetRenderPassId.layerId == id());
131 131
132 int renderPassIndex = idToIndex(targetRenderPassId.index); 132 int renderPassIndex = idToIndex(targetRenderPassId.index);
133 RenderPass* delegatedRenderPass = m_renderPassesInDrawOrder[renderPassIn dex]; 133 RenderPass* delegatedRenderPass = m_renderPassesInDrawOrder[renderPassIn dex];
134 appendRenderPassQuads(quadSink, appendQuadsData, delegatedRenderPass); 134 appendRenderPassQuads(quadSink, appendQuadsData, delegatedRenderPass);
135 } 135 }
136 } 136 }
137 137
138 void DelegatedRendererLayerImpl::appendRenderPassQuads(QuadSink& quadSink, Appen dQuadsData& appendQuadsData, RenderPass* delegatedRenderPass) const 138 void DelegatedRendererLayerImpl::appendRenderPassQuads(QuadSink& quadSink, Appen dQuadsData& appendQuadsData, RenderPass* delegatedRenderPass) const
139 { 139 {
140 const SharedQuadState* currentSharedQuadState = 0; 140 const SharedQuadState* currentSharedQuadState = 0;
141 SharedQuadState* copiedSharedQuadState = 0; 141 SharedQuadState* copiedSharedQuadState = 0;
142 for (size_t i = 0; i < delegatedRenderPass->quadList().size(); ++i) { 142 for (size_t i = 0; i < delegatedRenderPass->quadList().size(); ++i) {
143 const DrawQuad* quad = delegatedRenderPass->quadList()[i]; 143 const DrawQuad* quad = delegatedRenderPass->quadList()[i];
144 144
145 if (quad->shared_quad_state != currentSharedQuadState) { 145 if (quad->shared_quad_state != currentSharedQuadState) {
146 currentSharedQuadState = quad->shared_quad_state; 146 currentSharedQuadState = quad->shared_quad_state;
147 copiedSharedQuadState = quadSink.useSharedQuadState(currentSharedQua dState->copy()); 147 copiedSharedQuadState = quadSink.useSharedQuadState(currentSharedQua dState->copy());
148 bool targetIsFromDelegatedRendererLayer = appendQuadsData.renderPass Id.layerId == id(); 148 bool targetIsFromDelegatedRendererLayer = appendQuadsData.renderPass Id.layerId == id();
149 if (!targetIsFromDelegatedRendererLayer) { 149 if (!targetIsFromDelegatedRendererLayer) {
150 // Should be the root render pass. 150 // Should be the root render pass.
151 DCHECK(delegatedRenderPass == m_renderPassesInDrawOrder.last()); 151 DCHECK(delegatedRenderPass == m_renderPassesInDrawOrder.back());
152 // This layer must be drawing to a renderTarget other than itself. 152 // This layer must be drawing to a renderTarget other than itself.
153 DCHECK(renderTarget() != this); 153 DCHECK(renderTarget() != this);
154 154
155 copiedSharedQuadState->clippedRectInTarget = MathUtil::mapClippedR ect(drawTransform(), copiedSharedQuadState->clippedRectInTarget); 155 copiedSharedQuadState->clippedRectInTarget = MathUtil::mapClippedR ect(drawTransform(), copiedSharedQuadState->clippedRectInTarget);
156 copiedSharedQuadState->quadTransform = copiedSharedQuadState->quad Transform * drawTransform(); 156 copiedSharedQuadState->quadTransform = copiedSharedQuadState->quad Transform * drawTransform();
157 copiedSharedQuadState->opacity *= drawOpacity(); 157 copiedSharedQuadState->opacity *= drawOpacity();
158 } 158 }
159 } 159 }
160 DCHECK(copiedSharedQuadState); 160 DCHECK(copiedSharedQuadState);
161 161
(...skipping 12 matching lines...) Expand all
174 quadSink.append(copyQuad.Pass(), appendQuadsData); 174 quadSink.append(copyQuad.Pass(), appendQuadsData);
175 } 175 }
176 } 176 }
177 177
178 const char* DelegatedRendererLayerImpl::layerTypeAsString() const 178 const char* DelegatedRendererLayerImpl::layerTypeAsString() const
179 { 179 {
180 return "DelegatedRendererLayer"; 180 return "DelegatedRendererLayer";
181 } 181 }
182 182
183 } // namespace cc 183 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/delegated_renderer_layer_impl_unittest.cc » ('j') | cc/scoped_ptr_deque.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698