Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: runtime/vm/object.h

Issue 11418098: Address review comments of https://codereview.chromium.org/11299020/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_OBJECT_H_ 5 #ifndef VM_OBJECT_H_
6 #define VM_OBJECT_H_ 6 #define VM_OBJECT_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/utils.h" 10 #include "platform/utils.h"
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 598
599 // Check if this class represents the 'dynamic' class. 599 // Check if this class represents the 'dynamic' class.
600 bool IsDynamicClass() const { return id() == kDynamicCid; } 600 bool IsDynamicClass() const { return id() == kDynamicCid; }
601 601
602 // Check if this class represents the 'void' class. 602 // Check if this class represents the 'void' class.
603 bool IsVoidClass() const { return id() == kVoidCid; } 603 bool IsVoidClass() const { return id() == kVoidCid; }
604 604
605 // Check if this class represents the 'Object' class. 605 // Check if this class represents the 'Object' class.
606 bool IsObjectClass() const { return id() == kInstanceCid; } 606 bool IsObjectClass() const { return id() == kInstanceCid; }
607 607
608 // Check if this class represents the 'List' class.
609 bool IsListClass() const;
610
608 // Check if this class represents a signature class. 611 // Check if this class represents a signature class.
609 bool IsSignatureClass() const { 612 bool IsSignatureClass() const {
610 return signature_function() != Object::null(); 613 return signature_function() != Object::null();
611 } 614 }
612 static bool IsSignatureClass(RawClass* cls) { 615 static bool IsSignatureClass(RawClass* cls) {
613 return cls->ptr()->signature_function_ != Object::null(); 616 return cls->ptr()->signature_function_ != Object::null();
614 } 617 }
615 618
616 // Check if this class represents a canonical signature class, i.e. not an 619 // Check if this class represents a canonical signature class, i.e. not an
617 // alias as defined in a typedef. 620 // alias as defined in a typedef.
(...skipping 5338 matching lines...) Expand 10 before | Expand all | Expand 10 after
5956 if (this->CharAt(i) != str.CharAt(begin_index + i)) { 5959 if (this->CharAt(i) != str.CharAt(begin_index + i)) {
5957 return false; 5960 return false;
5958 } 5961 }
5959 } 5962 }
5960 return true; 5963 return true;
5961 } 5964 }
5962 5965
5963 } // namespace dart 5966 } // namespace dart
5964 5967
5965 #endif // VM_OBJECT_H_ 5968 #endif // VM_OBJECT_H_
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698