Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: runtime/vm/object.cc

Issue 11418098: Address review comments of https://codereview.chromium.org/11299020/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/bigint_operations.h" 10 #include "vm/bigint_operations.h"
(...skipping 2025 matching lines...) Expand 10 before | Expand all | Expand 10 after
2036 } 2036 }
2037 2037
2038 2038
2039 void Class::set_allocation_stub(const Code& value) const { 2039 void Class::set_allocation_stub(const Code& value) const {
2040 ASSERT(!value.IsNull()); 2040 ASSERT(!value.IsNull());
2041 ASSERT(raw_ptr()->allocation_stub_ == Code::null()); 2041 ASSERT(raw_ptr()->allocation_stub_ == Code::null());
2042 StorePointer(&raw_ptr()->allocation_stub_, value.raw()); 2042 StorePointer(&raw_ptr()->allocation_stub_, value.raw());
2043 } 2043 }
2044 2044
2045 2045
2046 bool Class::IsListClass() const {
2047 return raw() == Isolate::Current()->object_store()->list_class();
2048 }
2049
2050
2046 bool Class::IsCanonicalSignatureClass() const { 2051 bool Class::IsCanonicalSignatureClass() const {
2047 const Function& function = Function::Handle(signature_function()); 2052 const Function& function = Function::Handle(signature_function());
2048 return (!function.IsNull() && (function.signature_class() == raw())); 2053 return (!function.IsNull() && (function.signature_class() == raw()));
2049 } 2054 }
2050 2055
2051 2056
2052 // If test_kind == kIsSubtypeOf, checks if type S is a subtype of type T. 2057 // If test_kind == kIsSubtypeOf, checks if type S is a subtype of type T.
2053 // If test_kind == kIsMoreSpecificThan, checks if S is more specific than T. 2058 // If test_kind == kIsMoreSpecificThan, checks if S is more specific than T.
2054 // Type S is specified by this class parameterized with 'type_arguments', and 2059 // Type S is specified by this class parameterized with 'type_arguments', and
2055 // type T by class 'other' parameterized with 'other_type_arguments'. 2060 // type T by class 'other' parameterized with 'other_type_arguments'.
(...skipping 10105 matching lines...) Expand 10 before | Expand all | Expand 10 after
12161 } 12166 }
12162 return result.raw(); 12167 return result.raw();
12163 } 12168 }
12164 12169
12165 12170
12166 const char* WeakProperty::ToCString() const { 12171 const char* WeakProperty::ToCString() const {
12167 return "_WeakProperty"; 12172 return "_WeakProperty";
12168 } 12173 }
12169 12174
12170 } // namespace dart 12175 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698