Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 11418098: Address review comments of https://codereview.chromium.org/11299020/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 type_arguments.IsRaw(type_arguments.Length()); 151 type_arguments.IsRaw(type_arguments.Length());
152 if (is_raw_type) { 152 if (is_raw_type) {
153 const Register kClassIdReg = ECX; 153 const Register kClassIdReg = ECX;
154 // dynamic type argument, check only classes. 154 // dynamic type argument, check only classes.
155 // List is a very common case. 155 // List is a very common case.
156 __ LoadClassId(kClassIdReg, kInstanceReg); 156 __ LoadClassId(kClassIdReg, kInstanceReg);
157 if (!type_class.is_interface()) { 157 if (!type_class.is_interface()) {
158 __ cmpl(kClassIdReg, Immediate(type_class.id())); 158 __ cmpl(kClassIdReg, Immediate(type_class.id()));
159 __ j(EQUAL, is_instance_lbl); 159 __ j(EQUAL, is_instance_lbl);
160 } 160 }
161 if (type_class.raw() == Isolate::Current()->object_store()->list_class()) { 161 if (type_class.IsListClass()) {
162 GenerateListTypeCheck(kClassIdReg, is_instance_lbl); 162 GenerateListTypeCheck(kClassIdReg, is_instance_lbl);
163 } 163 }
164 return GenerateSubtype1TestCacheLookup( 164 return GenerateSubtype1TestCacheLookup(
165 token_pos, type_class, is_instance_lbl, is_not_instance_lbl); 165 token_pos, type_class, is_instance_lbl, is_not_instance_lbl);
166 } 166 }
167 // If one type argument only, check if type argument is Object or dynamic. 167 // If one type argument only, check if type argument is Object or dynamic.
168 if (type_arguments.Length() == 1) { 168 if (type_arguments.Length() == 1) {
169 const AbstractType& tp_argument = AbstractType::ZoneHandle( 169 const AbstractType& tp_argument = AbstractType::ZoneHandle(
170 type_arguments.TypeAt(0)); 170 type_arguments.TypeAt(0));
171 ASSERT(!tp_argument.IsMalformed()); 171 ASSERT(!tp_argument.IsMalformed());
(...skipping 1213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1385 __ popl(ECX); 1385 __ popl(ECX);
1386 __ popl(EAX); 1386 __ popl(EAX);
1387 } 1387 }
1388 1388
1389 1389
1390 #undef __ 1390 #undef __
1391 1391
1392 } // namespace dart 1392 } // namespace dart
1393 1393
1394 #endif // defined TARGET_ARCH_IA32 1394 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698