Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 11418042: Merge 134698 - [chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers when th… (Closed)

Created:
8 years, 1 month ago by Nico
Modified:
8 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 134698 - [chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers when the page is scaled https://bugs.webkit.org/show_bug.cgi?id=102282 Reviewed by James Robinson. Chromium uses skia, and skia state is synced with CG context state at LocalCurrentGraphicsContext construction time. So delay that construction after context transforms have happened. (This regressed in http://trac.webkit.org/changeset/125830) Covered by the new pixel test fast/forms/zoomed-controls.html. I couldn't find an existing test for this. * platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton): TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
A + LayoutTests/fast/forms/zoomed-controls.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/zoomed-controls-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/mac/ThemeMac.mm View 6 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 1 month ago (2012-11-16 20:24:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698