Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: cc/math_util.cc

Issue 11418040: gfx::Transform API clean-up (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/math_util.h ('k') | cc/math_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/math_util.cc
diff --git a/cc/math_util.cc b/cc/math_util.cc
index 2f885f865c2b0be25dd81655164e4a40fa295000..a9c0c827bff14f7d558814ce976a5edbf6206305 100644
--- a/cc/math_util.cc
+++ b/cc/math_util.cc
@@ -461,10 +461,8 @@ void MathUtil::rotateEulerAngles(gfx::Transform* transform, double eulerX, doubl
void MathUtil::rotateAxisAngle(gfx::Transform* transform, double i, double j, double k, double degrees)
{
- // TODO (shawnsingh): fix gfx::Transform API to receive vector instead of
- // point for the axis.
- gfx::Point3F axis(i, j, k);
- transform->PreconcatRotateAbout(axis, degrees);
+ gfx::Vector3dF axis(i, j, k);
+ transform->RotateAbout(axis, degrees);
}
gfx::Transform MathUtil::inverse(const gfx::Transform& transform)
@@ -545,12 +543,4 @@ gfx::Transform MathUtil::createGfxTransform(double a, double b, double c,
return result;
}
-gfx::Transform operator*(const gfx::Transform& A, const gfx::Transform& B)
-{
- // Compute A * B.
- gfx::Transform result = A;
- result.PreconcatTransform(B);
- return result;
-}
-
} // namespace cc
« no previous file with comments | « cc/math_util.h ('k') | cc/math_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698